Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PropertySelector] Fixed group selection #1536

Merged
merged 2 commits into from
Feb 14, 2021

Conversation

siad007
Copy link
Member

@siad007 siad007 commented Feb 14, 2021

Fixes and closes #1532 also changed group selctor to $ instead of \.

@codecov
Copy link

codecov bot commented Feb 14, 2021

Codecov Report

Merging #1536 (b9b7bc1) into main (dda8283) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #1536      +/-   ##
============================================
- Coverage     55.61%   55.59%   -0.02%     
+ Complexity     6909     6908       -1     
============================================
  Files           356      356              
  Lines         16732    16720      -12     
============================================
- Hits           9305     9295      -10     
+ Misses         7427     7425       -2     
Impacted Files Coverage Δ Complexity Δ
...rc/Phing/Task/System/Property/PropertySelector.php 96.87% <100.00%> (+3.69%) 14.00 <0.00> (-1.00) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dda8283...59e1e7b. Read the comment docs.

siad007 added a commit to phingofficial/guide that referenced this pull request Feb 14, 2021
@siad007 siad007 changed the title Fixed group selection [PropertySelector] Fixed group selection Feb 14, 2021
@siad007 siad007 merged commit 3465599 into phingofficial:main Feb 14, 2021
@siad007 siad007 deleted the PropertySelctor branch February 14, 2021 00:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

PropertySelector always selects the last subpattern regardless of the value of select
1 participant