Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wrong boolean handling #1680

Merged
merged 39 commits into from
Jul 26, 2022
Merged

Fix wrong boolean handling #1680

merged 39 commits into from
Jul 26, 2022

Conversation

jawira
Copy link
Contributor

@jawira jawira commented Jul 9, 2022

Hello, some boolean values weren't handled properly.

  • Target
    • hidden attribute
  • ModifiedSelector
    • update attribute
    • delayupdate attribute
    • seldirs attribute

jawira and others added 30 commits February 11, 2019 14:27
@codecov
Copy link

codecov bot commented Jul 9, 2022

Codecov Report

Merging #1680 (956972d) into main (d4b692c) will not change coverage.
The diff coverage is 50.00%.

@@            Coverage Diff            @@
##               main    #1680   +/-   ##
=========================================
  Coverage     58.34%   58.34%           
+ Complexity     6962     6961    -1     
=========================================
  Files           355      355           
  Lines         16611    16611           
=========================================
  Hits           9692     9692           
  Misses         6919     6919           
Impacted Files Coverage Δ
src/Phing/Parser/TargetHandler.php 83.16% <0.00%> (ø)
src/Phing/Type/Selector/ModifiedSelector.php 76.87% <66.66%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d4b692c...956972d. Read the comment docs.

@mrook mrook merged commit 86d527e into phingofficial:main Jul 26, 2022
@mrook mrook added this to the 3.0.0-RC4 milestone Jul 26, 2022
@jawira jawira deleted the hidden-bug branch August 9, 2022 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants