Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wrong boolean handling #1680

Merged
merged 39 commits into from
Jul 26, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
39 commits
Select commit Hold shift + click to select a range
fe38a90
Merge remote-tracking branch 'upstream/master'
jawira Feb 11, 2019
974a2f1
Merge remote-tracking branch 'upstream/master'
jawira Jul 1, 2019
c3b1e48
Merge remote-tracking branch 'upstream/master'
jawira Jul 12, 2019
32e4914
Merge remote-tracking branch 'upstream/master'
jawira Jul 26, 2019
275cc96
Merge remote-tracking branch 'upstream/master'
jawira Oct 23, 2019
4de09d3
ComposerTask: update code & doc #1163
jawira Oct 23, 2019
64aefbf
Merge branch 'master' of github.com:jawira/fork-phing
jawira Nov 19, 2019
d769c90
Merge remote-tracking branch 'upstream/master'
jawira Nov 19, 2019
9d8da67
Merge remote-tracking branch 'upstream/master'
jawira Aug 8, 2020
2549e00
Merge remote-tracking branch 'upstream/master'
jawira Sep 5, 2020
b57b6da
Merge remote-tracking branch 'upstream/master'
jawira Sep 29, 2020
ec4ab93
Merge remote-tracking branch 'upstream/master'
jawira Oct 17, 2020
8f5343c
Merge remote-tracking branch 'upstream/master'
jawira Oct 29, 2020
d098a0f
Merge remote-tracking branch 'upstream/master'
jawira Dec 14, 2020
c7bcabf
Merge remote-tracking branch 'upstream/master'
jawira Dec 19, 2020
919e771
Merge remote-tracking branch 'upstream/main' into main
jawira Feb 2, 2021
424a754
Merge remote-tracking branch 'upstream/main'
jawira Mar 9, 2021
f79dc57
Merge remote-tracking branch 'upstream/main'
jawira Mar 16, 2021
12c46e9
Merge remote-tracking branch 'upstream/main' into main
jawira Apr 19, 2021
605d358
Merge remote-tracking branch 'upstream/main' into main
jawira Apr 26, 2021
342c9ac
Merge remote-tracking branch 'upstream/main' into main
jawira May 4, 2021
8451ae1
Merge remote-tracking branch 'upstream/main' into main
jawira May 16, 2021
bd5938e
Merge remote-tracking branch 'upstream/main' into main
jawira Jun 12, 2021
180cea1
Merge branch 'phingofficial:main' into main
jawira Jul 15, 2021
3fc32f0
Merge branch 'main' of github.com:jawira/fork-phing into main
jawira Jul 15, 2021
7f4b766
Merge branch 'phingofficial:main' into main
jawira Sep 1, 2021
be081b8
Merge branch 'phingofficial:main' into main
jawira Sep 2, 2021
642f834
Merge branch 'phingofficial:main' into main
jawira Sep 5, 2021
32abe87
Merge branch 'phingofficial:main' into main
jawira Sep 11, 2021
4874f43
Merge branch 'phingofficial:main' into main
jawira Sep 19, 2021
552975b
Merge branch 'phingofficial:main' into main
jawira Sep 21, 2021
d0f2c6f
Merge branch 'phingofficial:main' into main
jawira Oct 7, 2021
e620b41
Merge branch 'phingofficial:main' into main
jawira Nov 23, 2021
d20c869
Merge branch 'phingofficial:main' into main
jawira Dec 2, 2021
cb21aae
Merge branch 'phingofficial:main' into main
jawira Mar 6, 2022
1ffdba8
Merge branch 'phingofficial:main' into main
jawira May 18, 2022
194d65b
Merge branch 'phingofficial:main' into main
jawira May 27, 2022
b51de43
Merge branch 'phingofficial:main' into main
jawira Jul 9, 2022
956972d
fix: Some attributes are not handled as proper boolean values.
jawira Jul 9, 2022
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Phing/Parser/TargetHandler.php
Original file line number Diff line number Diff line change
Expand Up @@ -137,7 +137,7 @@ public function init($tag, $attrs)
break;

case 'hidden':
$isHidden = ('true' === $value || '1' === $value);
$isHidden = StringHelper::booleanValue($value);

break;

Expand Down
6 changes: 3 additions & 3 deletions src/Phing/Type/Selector/ModifiedSelector.php
Original file line number Diff line number Diff line change
Expand Up @@ -253,11 +253,11 @@ public function useParameter(Parameter $parameter): void
} elseif ('comparator' === $key) {
$this->setComparator($value);
} elseif ('update' === $key) {
$this->setUpdate('true' === strtolower($value));
$this->setUpdate(StringHelper::booleanValue($value));
} elseif ('delayupdate' === $key) {
$this->setDelayUpdate('true' === strtolower($value));
$this->setDelayUpdate(StringHelper::booleanValue($value));
} elseif ('seldirs' === $key) {
$this->setSeldirs('true' === strtolower($value));
$this->setSeldirs(StringHelper::booleanValue($value));
} elseif (StringHelper::startsWith(self::CACHE_PREFIX, $key)) {
$name = StringHelper::substring($key, strlen(self::CACHE_PREFIX));
$this->tryToSetAParameter($this->cache, $name, $value);
Expand Down