Add copious debugging with --debug
#2555
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I love sprinkles! 🍨 🍰 If you update this for conflicts I'm good to merge this - you can go ahead and merge when it's updated. 👍 |
- add new file "cask/utils.rb" analogous to "utils.rb" in Homebrew - define odebug and odumpcask, analogs of ohai and friends, but which only give output when --debug is in effect - move the debug setting from an instance variable in Cask::CLI to a method Cask.debug, defined in "lib/cask/options.rb", which was added in Homebrew#2276. (Perhaps options.rb should be merged back into Cask::CLI). - sprinkle odebug statements liberally throughout the codebase - update tests
rolandwalker
added a commit
that referenced
this pull request
Jan 28, 2014
Add copious debugging with `--debug`
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cask/utils.rbanalogous toutils.rbin Homebrewodebugandodumpcask, analogs ofohaiand friends, butwhich only give output when
--debugis in effectCask::CLIto a method
Cask.debug, defined inlib/cask/options.rb, whichwas added in Implement
binaryartifact #2276. (Perhapsoptions.rbshould be merged backinto
Cask::CLI).odebugstatements liberally throughout the codebaseThe intention is to provide output which might be useful to Cask authors, to
see where things go awry, or for users and Cask authors to produce gists
for developers.