Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement flag "skip-push", deprecate flag "push" #143

Merged

Conversation

rosshamish
Copy link
Contributor

  • Implements a new input flag skip-push, default false. If true, skips pushing any commit or tag created during the version bump.
  • Deprecates the input flag push, which was documented as skipping the push, but whose actual behavior is to skip all operations (version bump in package.json, git commit, git tag, git push). In a future major version, this flag could be renamed to no-op, or even just removed since its behavior can be achieved using the if: conditionals in Github Actions anyway.

Tested using the end-to-end test suite (needed some modifications before it would run), over here: https://github.com/rosshamish/gh-action-bump-version/pull/1/checks

This was referenced Dec 9, 2021
@phips28 phips28 merged commit 53dc688 into phips28:master Dec 9, 2021
@phips28
Copy link
Owner

phips28 commented Dec 9, 2021

thx 🙂

I never used the test suite, as it never worked for me 🙈

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants