Skip to content

Commit

Permalink
revert "out_kafka: make MSVC compatible (fluent#1179)" (fluent#1832)
Browse files Browse the repository at this point in the history
This reverts commit 69fffab.

Bakashar Kemerbay (and many other Windows users) reports that it
causes an immediate abort on Windows environments. In particular,
it causes abort even when they does not use out_kafka.

For example, I can confirm that even the following command does
not work on a vanilla Windows server.

    $ fluent-bit.exe -i dummy -o stdout

This is because librdkafka is dependent on OpenSSL (ssleay32.dll
and libeay32.dll), which most Windows servers do not have. Hence
fluent-bit.exe always fails due to missing DLL dependencies.

So we have to revert this, and revisit it after resolving the
dependency issue.

Signed-off-by: Fujimoto Seiji <fujimoto@clear-code.com>
  • Loading branch information
Fujimoto Seiji authored and edsiper committed Dec 23, 2019
1 parent 93d4d53 commit b0191b6
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 4 deletions.
2 changes: 1 addition & 1 deletion cmake/windows-setup.cmake
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ set(FLB_OUT_STDOUT Yes)
set(FLB_OUT_LIB No)
set(FLB_OUT_NULL Yes)
set(FLB_OUT_FLOWCOUNTER Yes)
set(FLB_OUT_KAFKA Yes)
set(FLB_OUT_KAFKA No)
set(FLB_OUT_KAFKA_REST No)

# FILTER plugins
Expand Down
4 changes: 1 addition & 3 deletions plugins/out_kafka/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,4 @@ set(src
kafka.c)

FLB_PLUGIN(out_kafka "${src}" "rdkafka")
if (NOT MSVC)
target_link_libraries(flb-plugin-out_kafka -lpthread)
endif()
target_link_libraries(flb-plugin-out_kafka -lpthread)

0 comments on commit b0191b6

Please sign in to comment.