Unbreak build on FreeBSD #11
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/xdg_shell.c:119:9: error: expected expression
119 | wlmtk_window_t *window_ptr = wlmtk_window_create_from_xdg_toplevel(
| ^
src/xdg_shell.c:122:16: error: use of undeclared identifier 'window_ptr'
122 | window_ptr, wlr_xdg_surface_ptr);
| ^
$ cmake -G Ninja -B /tmp/wlmaker_build [...] CMake Error: CMake can not determine linker language for target: protocol_headers -- Generating done (0.0s) CMake Generate step failed. Build files cannot be regenerated correctly.
ld: error: undefined symbol: signalfd >>> referenced by client.c >>> client.c.o:(wlclient_create) in archive apps/libwlclient/liblibwlclient.a
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Closed
|
w00t, that was quick! Happy to get the changes in, thanks for the suggestion of public domain. |
Merged
|
Due to merge conflicts & the amended ownership: Ended up in #19. Closing here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on phkaeser/libbase#2
Runtime requires
/procmounted for some features until ported tosysctl.Also packaged for easier testing.
I put my patches here into the public domain. CLA isn't an option for me due to lacking a Google Account which cannot be signed up for via Tor. Feel free to resubmit under differnt authorship (e.g.,
git commit --amend --reset-author) in order to satisfy CLA.