Test custom object method call precedence #700
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joeldrapper
reviewed
Apr 1, 2024
test/phlex/valueable_object.rb
Outdated
Comment on lines
38
to
40
| to_phlex_attribute_value_klass = Class.new { define_method(:to_phlex_attribute_value, -> { "to_phlex_attribute_value" }) } | ||
| to_str_klass = Class.new(to_phlex_attribute_value_klass) { define_method(:to_str, -> { "to_str" }) } | ||
| to_s_klass = Class.new(to_str_klass) { define_method(:to_s, -> { "to_s" }) } |
There was a problem hiding this comment.
I think this would need to be just one class with all three methods defined to ensure the to_phlex_attribute method “wins”.
There was a problem hiding this comment.
Thanks for the feedback @joeldrapper!
I refactored the test so that there is only one class that defines all three methods to ensure correct method call precedence
|
Hey @sullyvannunes, thanks so much for the PR. 🙏 I left some feedback on one of the tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to issue #638, it would be better to add coverage to the method call precedence of custom object attribute building.