-
-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test custom object method call precedence #700
Merged
Merged
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,47 @@ | ||
# frozen_string_literal: true | ||
|
||
describe Phlex::HTML do | ||
def build_component_with_template(&block) | ||
Class.new(Phlex::HTML) do | ||
define_method(:view_template, block) | ||
end | ||
end | ||
|
||
it "renders to_s class" do | ||
klass = Class.new { define_method(:to_s, -> { "to_s" }) } | ||
component = build_component_with_template do | ||
div class: klass.new | ||
end | ||
|
||
expect(component.call).to be == %(<div class="to_s"></div>) | ||
end | ||
|
||
it "renders to_str class" do | ||
klass = Class.new { define_method(:to_str, -> { "to_str" }) } | ||
component = build_component_with_template do | ||
div class: klass.new | ||
end | ||
|
||
expect(component.call).to be == %(<div class="to_str"></div>) | ||
end | ||
|
||
it "renders to_phlex_attribute_value class" do | ||
klass = Class.new { define_method(:to_phlex_attribute_value, -> { "to_phlex_attribute_value" }) } | ||
component = build_component_with_template do | ||
div class: klass.new | ||
end | ||
|
||
expect(component.call).to be == %(<div class="to_phlex_attribute_value"></div>) | ||
end | ||
|
||
it "renders phlex attribute value according to method call precedence" do | ||
to_phlex_attribute_value_klass = Class.new { define_method(:to_phlex_attribute_value, -> { "to_phlex_attribute_value" }) } | ||
to_str_klass = Class.new(to_phlex_attribute_value_klass) { define_method(:to_str, -> { "to_str" }) } | ||
to_s_klass = Class.new(to_str_klass) { define_method(:to_s, -> { "to_s" }) } | ||
component = build_component_with_template do | ||
div class: to_s_klass.new | ||
end | ||
|
||
expect(component.call).to be == %(<div class="to_phlex_attribute_value"></div>) | ||
end | ||
end |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this would need to be just one class with all three methods defined to ensure the
to_phlex_attribute
method “wins”.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the feedback @joeldrapper!
I refactored the test so that there is only one class that defines all three methods to ensure correct method call precedence