Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test custom object method call precedence #700

Merged
merged 2 commits into from
Apr 2, 2024
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
47 changes: 47 additions & 0 deletions test/phlex/valueable_object.rb
Original file line number Diff line number Diff line change
@@ -0,0 +1,47 @@
# frozen_string_literal: true

describe Phlex::HTML do
def build_component_with_template(&block)
Class.new(Phlex::HTML) do
define_method(:view_template, block)
end
end

it "renders to_s class" do
klass = Class.new { define_method(:to_s, -> { "to_s" }) }
component = build_component_with_template do
div class: klass.new
end

expect(component.call).to be == %(<div class="to_s"></div>)
end

it "renders to_str class" do
klass = Class.new { define_method(:to_str, -> { "to_str" }) }
component = build_component_with_template do
div class: klass.new
end

expect(component.call).to be == %(<div class="to_str"></div>)
end

it "renders to_phlex_attribute_value class" do
klass = Class.new { define_method(:to_phlex_attribute_value, -> { "to_phlex_attribute_value" }) }
component = build_component_with_template do
div class: klass.new
end

expect(component.call).to be == %(<div class="to_phlex_attribute_value"></div>)
end

it "renders phlex attribute value according to method call precedence" do
to_phlex_attribute_value_klass = Class.new { define_method(:to_phlex_attribute_value, -> { "to_phlex_attribute_value" }) }
to_str_klass = Class.new(to_phlex_attribute_value_klass) { define_method(:to_str, -> { "to_str" }) }
to_s_klass = Class.new(to_str_klass) { define_method(:to_s, -> { "to_s" }) }
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this would need to be just one class with all three methods defined to ensure the to_phlex_attribute method “wins”.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the feedback @joeldrapper!

I refactored the test so that there is only one class that defines all three methods to ensure correct method call precedence

component = build_component_with_template do
div class: to_s_klass.new
end

expect(component.call).to be == %(<div class="to_phlex_attribute_value"></div>)
end
end