Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support upstream League Oauth2 Clients. #3

Open
wants to merge 6 commits into
base: develop
from

Conversation

Projects
None yet
1 participant
@nynka
Copy link

commented May 27, 2019

This new feature adds the ability to use any League Oauth2 Client that inherits from League\OAuth2\Client\Provider\AbstractProvider by adding providers of their choice to their local configuration.

  • Are you fixing a bug?

    • Detail how the bug is invoked currently.
    • Detail the original, incorrect behavior.
    • Detail the new, expected behavior.
    • Base your feature on the master branch, and submit against that branch.
    • Add a regression test that demonstrates the bug, and proves the fix.
    • Add a CHANGELOG.md entry for the fix.
  • Are you creating a new feature?

    • Why is the new feature needed? What purpose does it serve?
    • How will users use the new feature?
    • Base your feature on the develop branch, and submit against that branch.
    • Add only one feature per pull request; split multiple features over multiple pull requests
    • Add tests for the new feature.
    • Add documentation for the new feature.
    • Add a CHANGELOG.md entry for the new feature.
  • Is this related to quality assurance?

  • Is this related to documentation?

@nynka nynka marked this pull request as ready for review May 27, 2019

@nynka

This comment has been minimized.

Copy link
Author

commented May 28, 2019

Ping for review @weierophinney

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.