Support upstream League Oauth2 Clients. #3
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ping for review @weierophinney |
|
Find any time to review this @weierophinney ? :) |
weierophinney
requested changes
Sep 20, 2019
There was a problem hiding this comment.
This looks fantastic, @nynka! I've flagged a few documentation changes, but once those are ready, I'm ready to merge this and release a new major version.
- Remove implementation and test details in changelog - Fix typos "Client/client", "s/inherits/inherit/"
weierophinney
requested changes
Oct 2, 2019
- Link to the relevant documentation (full URL) in changelog - Explanation of the "custom" provider
Consider it done. Thank you for great feedback! @weierophinney |
weierophinney
added a commit
that referenced
this pull request
Nov 12, 2019
This patch updates the CHANGELOG entries for #3 to reference the pull request, so users can understand the source of the change. Additionally, it pushes the new version entry to the top of the file (CHANGELOG.md files list in reverse chronological order), sets the version to 2.0.0, and sets the release date.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This new feature adds the ability to use any League Oauth2 Client that inherits from League\OAuth2\Client\Provider\AbstractProvider by adding providers of their choice to their local configuration.
Are you fixing a bug?
masterbranch, and submit against that branch.CHANGELOG.mdentry for the fix.Are you creating a new feature?
developbranch, and submit against that branch.CHANGELOG.mdentry for the new feature.Is this related to quality assurance?
Is this related to documentation?