hotfix/NmrML datatype #39
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djcomlab
requested review from
michaelvanvliet,
sneumann,
ilveroluca,
c-ruttkies,
pkrog and
korseby
|
Can someone else check this works? I have no experience with nmrML, but it looks like a diff between releases shows the NmrML class I am adding in this PR disappeared between releases. |
|
I found the datatype class already existing in our container image repository, under |
|
Ah OK! If that works we can ignore and close this PR. |
sneumann
requested changes
Jul 24, 2018
There was a problem hiding this comment.
As Luca mentioned in phnmnl/container-galaxy-k8s-runtime#289 (comment), the fix should be something different.
I suggest closing this PR and do that instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add back missing NmrML datatype from 17.01 release to fix #38.