Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

algebra: additional tests for matrix_zeroes() function #60

Merged
merged 2 commits into from
Aug 25, 2022

Conversation

PNieck
Copy link
Contributor

@PNieck PNieck commented Aug 24, 2022

JIRA: PP-71

Description

This PR is adding additional tests for matrix_zeroes

Motivation and Context

More precise testing

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

How Has This Been Tested?

  • Already covered by automatic testing.
  • New test added: (add PR link here).
  • Tested by hand on: (list targets here). rmv7a9-zynq7000-qemu

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing linter checks and tests passed.
  • My changes generate no new compilation warnings for any of the targets.

Special treatment

  • This PR needs additional PRs to work (list the PRs, preferably in merge-order).
  • I will merge this PR by myself when appropriate.

@PNieck PNieck requested a review from niewim19 August 24, 2022 15:30
@PNieck PNieck force-pushed the PNieck/additional_test_for_matrix_zeroes branch from 46ad2f1 to 2f982c3 Compare August 24, 2022 15:32
Copy link
Collaborator

@niewim19 niewim19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, main remarks are about strange value set to matrix and error presentation when check for zero fails

algebra/tests/matrix/various.c Outdated Show resolved Hide resolved
algebra/tests/matrix/various.c Outdated Show resolved Hide resolved
algebra/tests/matrix/various.c Outdated Show resolved Hide resolved
@PNieck PNieck force-pushed the PNieck/additional_test_for_matrix_zeroes branch from 2f982c3 to 1a11ea6 Compare August 25, 2022 08:52
@PNieck PNieck requested a review from niewim19 August 25, 2022 08:53
@PNieck PNieck force-pushed the PNieck/additional_test_for_matrix_zeroes branch 2 times, most recently from db491c3 to c08c32e Compare August 25, 2022 10:04
@PNieck PNieck force-pushed the PNieck/additional_test_for_matrix_zeroes branch from c08c32e to 163cee1 Compare August 25, 2022 11:13
Copy link
Collaborator

@niewim19 niewim19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@PNieck PNieck merged commit c76a8e3 into main Aug 25, 2022
@PNieck PNieck deleted the PNieck/additional_test_for_matrix_zeroes branch August 26, 2022 13:04
PNieck pushed a commit that referenced this pull request Sep 14, 2022
* libphoenix bf17f5a...d678a85 (3):
  > fixing errno of `rmdir()` and `chdir()` when not called on a directory (#162)
  > getline(): correct size handling + little refactor (#163)
  > f*open(): fix closing and errno (#161)

* phoenix-rtos-build c8fcf12...3e94364 (1):
  > build: don't build tests on 'all'

* phoenix-rtos-doc bd651b2...d5ab783 (2):
  > corelibs: expand libgraph documentation
  > add msgSend(), msgRecv(), msgRespond() functions documentation

* phoenix-rtos-filesystems 2316e74...5da9564 (1):
  > ext2: unlink not empty dir correct errno (#60)

* phoenix-rtos-ports b28bb68...e2fca88 (1):
  > jansson: fix incremental build
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants