-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
algebra: additional tests for matrix_zeroes()
function
#60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
46ad2f1
to
2f982c3
Compare
niewim19
requested changes
Aug 25, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, main remarks are about strange value set to matrix and error presentation when check for zero fails
2f982c3
to
1a11ea6
Compare
db491c3
to
c08c32e
Compare
c08c32e
to
163cee1
Compare
niewim19
approved these changes
Aug 25, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
PNieck
pushed a commit
that referenced
this pull request
Sep 14, 2022
* libphoenix bf17f5a...d678a85 (3): > fixing errno of `rmdir()` and `chdir()` when not called on a directory (#162) > getline(): correct size handling + little refactor (#163) > f*open(): fix closing and errno (#161) * phoenix-rtos-build c8fcf12...3e94364 (1): > build: don't build tests on 'all' * phoenix-rtos-doc bd651b2...d5ab783 (2): > corelibs: expand libgraph documentation > add msgSend(), msgRecv(), msgRespond() functions documentation * phoenix-rtos-filesystems 2316e74...5da9564 (1): > ext2: unlink not empty dir correct errno (#60) * phoenix-rtos-ports b28bb68...e2fca88 (1): > jansson: fix incremental build
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA: PP-71
Description
This PR is adding additional tests for
matrix_zeroes
Motivation and Context
More precise testing
Types of changes
How Has This Been Tested?
rmv7a9-zynq7000-qemu
Checklist:
Special treatment