Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

calib: calibration tool framework #73

Merged
merged 9 commits into from
Sep 9, 2022
Merged

calib: calibration tool framework #73

merged 9 commits into from
Sep 9, 2022

Conversation

niewim19
Copy link
Collaborator

@niewim19 niewim19 commented Sep 1, 2022 •
edited
Loading

  • used linked list for procedures registration
  • calibration file read/write procedures undeclared

JIRA: PP-89

Description

Drone calibration tool framework. Each calibration procedure registers itself via constructor using static structure from its source file.

Motivation and Context

Uses:

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

How Has This Been Tested?

  • Already covered by automatic testing.
  • New test added: (add PR link here).
  • Tested by hand on: (list targets here).

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing linter checks and tests passed.
  • My changes generate no new compilation warnings for any of the targets.

Special treatment

github-actions[bot]
github-actions bot reviewed Sep 1, 2022
View reviewed changes
calib/calib.h Outdated Show resolved Hide resolved
github-actions[bot]
github-actions bot reviewed Sep 1, 2022
View reviewed changes
calib/calib.h Outdated Show resolved Hide resolved
calib/main.c Outdated Show resolved Hide resolved
@niewim19 niewim19 force-pushed the niewim19/calbtool branch 2 times, most recently from 37fa8a0 to 476e2f6 Compare September 1, 2022 08:34
github-actions[bot]
github-actions bot reviewed Sep 1, 2022
View reviewed changes
calib/main.c Outdated Show resolved Hide resolved
calib/main.c Outdated Show resolved Hide resolved
HBuczynski
HBuczynski suggested changes Sep 1, 2022
View reviewed changes
calib/calib.h Outdated Show resolved Hide resolved
calib/calib.h Outdated Show resolved Hide resolved
calib/mag.c Outdated Show resolved Hide resolved
calib/mag.c Outdated Show resolved Hide resolved
calib/main.c Outdated Show resolved Hide resolved
calib/main.c Show resolved Hide resolved
calib/main.c Outdated Show resolved Hide resolved
github-actions[bot]
github-actions bot reviewed Sep 1, 2022
View reviewed changes
calib/mag.c Outdated Show resolved Hide resolved
calib/mag.c Outdated Show resolved Hide resolved
calib/main.c Outdated Show resolved Hide resolved
calib/main.c Outdated Show resolved Hide resolved
calib/main.c Outdated Show resolved Hide resolved
calib/main.c Outdated Show resolved Hide resolved
github-actions[bot]
github-actions bot reviewed Sep 1, 2022
View reviewed changes
calib/main.c Outdated Show resolved Hide resolved
github-actions[bot]
github-actions bot reviewed Sep 1, 2022
View reviewed changes
calib/calib.h Outdated Show resolved Hide resolved
@niewim19 niewim19 force-pushed the niewim19/calbtool branch 2 times, most recently from 22ec6cf to 99cce46 Compare September 1, 2022 14:17
github-actions[bot]
github-actions bot reviewed Sep 1, 2022
View reviewed changes
calib/mag.c Outdated Show resolved Hide resolved
@niewim19
Copy link
Collaborator Author

niewim19 commented Sep 1, 2022

This PR was heavily remodeled to use simple hash map implementation, thus probably need another, full review.

@niewim19 niewim19 force-pushed the niewim19/calbtool branch 2 times, most recently from 69c55c9 to bf2e85d Compare September 2, 2022 07:54
github-actions[bot]
github-actions bot reviewed Sep 2, 2022
View reviewed changes
calib/mag.c Outdated Show resolved Hide resolved
calib/mag.c Outdated Show resolved Hide resolved
github-actions[bot]
github-actions bot reviewed Sep 2, 2022
View reviewed changes
calib/mag.c Outdated Show resolved Hide resolved
calib/mag.c Outdated Show resolved Hide resolved
calib/mag.c Outdated Show resolved Hide resolved
calib/mag.c Outdated Show resolved Hide resolved
calib/mag.c Outdated Show resolved Hide resolved
calib/mag.c Outdated Show resolved Hide resolved
calib/mag.c Outdated Show resolved Hide resolved
calib/main.c Outdated Show resolved Hide resolved
calib/main.c Outdated Show resolved Hide resolved
github-actions[bot]
github-actions bot reviewed Sep 2, 2022
View reviewed changes
calib/mag.c Outdated Show resolved Hide resolved
@niewim19 niewim19 force-pushed the niewim19/calbtool branch 2 times, most recently from cafb627 to fde42df Compare September 2, 2022 10:08
@niewim19 niewim19 marked this pull request as ready for review September 2, 2022 10:09
@niewim19 niewim19 force-pushed the niewim19/calbtool branch 3 times, most recently from 9bff783 to 210a63c Compare September 5, 2022 08:21
github-actions[bot]
github-actions bot reviewed Sep 5, 2022
View reviewed changes
calib/hmap.c Outdated Show resolved Hide resolved
@niewim19 niewim19 force-pushed the niewim19/calbtool branch 2 times, most recently from d25c586 to d8e3c15 Compare September 7, 2022 13:54
github-actions[bot]
github-actions bot reviewed Sep 7, 2022
View reviewed changes
calib/magiron.c Outdated Show resolved Hide resolved
@niewim19 niewim19 force-pushed the niewim19/calbtool branch 3 times, most recently from fe47caa to 7becb1e Compare September 8, 2022 05:58
github-actions[bot]
github-actions bot reviewed Sep 8, 2022
View reviewed changes
calib/magmot.c Outdated Show resolved Hide resolved
calib/magmot.c Outdated Show resolved Hide resolved
@niewim19
Copy link
Collaborator Author

niewim19 commented Sep 8, 2022

Ready for review

@niewim19
calib: calibration tool framework
9903f7c 
 - simple hashmap implementation
 - procedures should register with constructor into hashmap
 - calibration file reading implementation
 - calibration file writing implementation

JIRA: PP-89
HBuczynski
HBuczynski suggested changes Sep 9, 2022
View reviewed changes
calib/calib.h Outdated Show resolved Hide resolved
calib/calib.h Outdated Show resolved Hide resolved
calib/hmap.h Outdated Show resolved Hide resolved
calib/hmap.h Outdated Show resolved Hide resolved
calib/hmap.h Outdated Show resolved Hide resolved
calib/magmot.c Show resolved Hide resolved
calib/magmot.c Outdated Show resolved Hide resolved
calib/main.c Outdated Show resolved Hide resolved
calib/main.c Show resolved Hide resolved
calib/main.c Show resolved Hide resolved
github-actions[bot]
github-actions bot reviewed Sep 9, 2022
View reviewed changes
calib/main.c Outdated Show resolved Hide resolved
@niewim19
Copy link
Collaborator Author

niewim19 commented Sep 9, 2022

Changes after review were implemented as separate commits in this branch history as follows:

  • Changes to main.c, hmap.h, hmap.c and calib.h were done in: 0df06c2
  • Changes to magmot calibration procedure were done in: c055cca
  • Changes to magiton calibration procedure were done in: e8c83e8

@niewim19 niewim19 merged commit 765b752 into main Sep 9, 2022
@niewim19 niewim19 deleted the niewim19/calbtool branch September 15, 2022 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions GitHub Actions github-actions left review comments

@HBuczynski HBuczynski HBuczynski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@niewim19 @HBuczynski