-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
algebra: adding tests for quat_add
function
#78
Conversation
e02d5f8
to
ca80292
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
algebra/tests/quat/various.c
Outdated
quat_t A = Q2; | ||
quat_t B = Q3; | ||
quat_t C = A; /* C is copy of A */ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No need for comment :) Code is sufficiently self explanatory. If you want to emphasize it even more you can write:
quat_t A = C = Q2;
quat_t B = Q3;
but let`s keep it simple as it is :) Not a blocker.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, I have deleted comment. BTW your suggestion won't work because C
if not defined here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh... yeah, my mistake. I meant:
quat_t A, B, C;
A = C = Q2;
B = Q3;
JIRA: PP-71
ca80292
to
034588f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
JIRA: PP-71
Description
This PR adds tests for
quat_add
function.Motivation and Context
More precise tests.
Types of changes
How Has This Been Tested?
armv7a9-zynq7000-qemu
Checklist:
Special treatment