algebra: adding tests for quat_add function
#78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
PNieck
force-pushed
the
PNieck/adding_tests_for_quat_add
branch
from
e02d5f8
to
ca80292
Compare
niewim19
previously approved these changes
Sep 5, 2022
algebra/tests/quat/various.c
Outdated
Comment on lines
127
to
129
| quat_t A = Q2; | ||
| quat_t B = Q3; | ||
| quat_t C = A; /* C is copy of A */ |
There was a problem hiding this comment.
No need for comment :) Code is sufficiently self explanatory. If you want to emphasize it even more you can write:
quat_t A = C = Q2;
quat_t B = Q3;but let`s keep it simple as it is :) Not a blocker.
There was a problem hiding this comment.
Ok, I have deleted comment. BTW your suggestion won't work because C if not defined here.
There was a problem hiding this comment.
Oh... yeah, my mistake. I meant:
quat_t A, B, C;
A = C = Q2;
B = Q3;JIRA: PP-71
PNieck
force-pushed
the
PNieck/adding_tests_for_quat_add
branch
from
ca80292
to
034588f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA: PP-71
Description
This PR adds tests for
quat_addfunction.Motivation and Context
More precise tests.
Types of changes
How Has This Been Tested?
armv7a9-zynq7000-qemuChecklist:
Special treatment