Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

algebra: adding tests for quat_cmp function #86

Merged
merged 1 commit into from
Sep 7, 2022

Conversation

PNieck
Copy link
Contributor

@PNieck PNieck commented Sep 6, 2022

JIRA: PP-71

Description

This PR adds tests for quat_cmp function

Motivation and Context

More precise tests

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

How Has This Been Tested?

  • Already covered by automatic testing.
  • New test added: (add PR link here).
  • Tested by hand on: (list targets here). armv7a9-zynq7000-qemu

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing linter checks and tests passed.
  • My changes generate no new compilation warnings for any of the targets.

Special treatment

  • This PR needs additional PRs to work (list the PRs, preferably in merge-order).
  • I will merge this PR by myself when appropriate.

@PNieck PNieck requested a review from niewim19 September 6, 2022 14:56
algebra/tests/quat/various.c Outdated Show resolved Hide resolved
algebra/tests/quat/various.c Outdated Show resolved Hide resolved
algebra/tests/quat/various.c Outdated Show resolved Hide resolved
algebra/tests/quat/various.c Outdated Show resolved Hide resolved
algebra/tests/quat/various.c Outdated Show resolved Hide resolved
algebra/tests/quat/various.c Outdated Show resolved Hide resolved
@PNieck PNieck force-pushed the PNieck/adding_tests_for_quat_cmp branch from c96c0d7 to ac76a9e Compare September 6, 2022 14:57
Copy link
Collaborator

@niewim19 niewim19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I get the idea of separate test for each component difference, but we can just check it in one test for simplicity.

algebra/tests/quat/various.c Outdated Show resolved Hide resolved
@PNieck PNieck force-pushed the PNieck/adding_tests_for_quat_cmp branch from ac76a9e to 2fa0918 Compare September 6, 2022 16:05
@PNieck PNieck force-pushed the PNieck/adding_tests_for_quat_cmp branch from 2fa0918 to cdfdfad Compare September 6, 2022 16:07
@PNieck PNieck requested a review from niewim19 September 6, 2022 16:08
Copy link
Collaborator

@niewim19 niewim19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@PNieck PNieck merged commit 61f25eb into main Sep 7, 2022
@PNieck PNieck deleted the PNieck/adding_tests_for_quat_cmp branch September 7, 2022 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants