Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Webpack 4 + ExtractTextPlugin issues #2818

Closed
LostKobrakai opened this issue Mar 23, 2018 · 1 comment · Fixed by #2831
Closed

Webpack 4 + ExtractTextPlugin issues #2818

LostKobrakai opened this issue Mar 23, 2018 · 1 comment · Fixed by #2831
Assignees
@Gazler

Comments

@LostKobrakai
Copy link
Contributor

As per the comments here it seems like efforts to support webpack 4 with the ExtractTextWebpackPlugin have come to a halt, while there are various issues with the existing beta version. Might be nice to have a look at alternatives until 1.4 is released.
@Gazler
Copy link
Member

Gazler commented Apr 5, 2018

Looks like https://github.com/webpack-contrib/mini-css-extract-plugin is the advised replacement.

Gazler added a commit to Gazler/phoenix that referenced this issue Apr 5, 2018
@Gazler
Replace extract-text-webpack-plugin with mini-css-extract-plugin
a896b69 
According to the TL;DR of the comment below, mini-css-extract-plugin is
replacing extract-text-webpack-plugin which will be deprecated. Since
this does not have a built in optimizer for CSS, a separate plugin is
used. However overriding the optimizer means that UglifyJS must be
included manually (previously this was a transitive dependency of
webpack which was used automatically in production mode)

webpack-contrib/extract-text-webpack-plugin#749 (comment)

This closes phoenixframework#2818
@Gazler Gazler mentioned this issue Apr 5, 2018
Merged
Gazler added a commit to Gazler/phoenix that referenced this issue Apr 5, 2018
@Gazler
Replace extract-text-webpack-plugin with mini-css-extract-plugin
9274756 
According to the TL;DR of the comment below, mini-css-extract-plugin is
replacing extract-text-webpack-plugin which will be deprecated. Since
this does not have a built in optimizer for CSS, a separate plugin is
used. However overriding the optimizer means that UglifyJS must be
included manually (previously this was a transitive dependency of
webpack which was used automatically in production mode)

webpack-contrib/extract-text-webpack-plugin#749 (comment)

This closes phoenixframework#2818
chrismccord pushed a commit that referenced this issue Apr 9, 2018
@Gazler @chrismccord
Replace extract-text-webpack-plugin with mini-css-extract-plugin (#2831)
5bd6222 
According to the TL;DR of the comment below, mini-css-extract-plugin is
replacing extract-text-webpack-plugin which will be deprecated. Since
this does not have a built in optimizer for CSS, a separate plugin is
used. However overriding the optimizer means that UglifyJS must be
included manually (previously this was a transitive dependency of
webpack which was used automatically in production mode)

webpack-contrib/extract-text-webpack-plugin#749 (comment)

This closes #2818
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Gazler Gazler

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Replace extract-text-webpack-plugin with mini-css-extract-plugin Gazler/phoenix
2 participants
@Gazler @LostKobrakai