Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use npm script for brunch watch tasks #1273

Merged
merged 1 commit into from
Oct 13, 2015
Merged

Use npm script for brunch watch tasks #1273

merged 1 commit into from
Oct 13, 2015

Conversation

jarofghosts
Copy link
Contributor

This is a follow-up to conversation that happened in #1270 . Moves the brunch watch --stdin call into an npm script.

@josevalim
Copy link
Member

👍

chrismccord added a commit that referenced this pull request Oct 13, 2015
@chrismccord
Merge pull request #1273 from jarofghosts/brunch-watch-npm-script
9c74379 
Use npm script for brunch watch tasks
@chrismccord chrismccord merged commit 9c74379 into phoenixframework:master Oct 13, 2015
@chrismccord
Copy link
Member

Thanks!

@jarofghosts jarofghosts mentioned this pull request Oct 13, 2015
Merged
@chrismccord
Copy link
Member

This change actually breaks brunch usage for someone on windows :(

I was troubleshooting a different brunch issue and had them try out the new npm script and watcher, and they get an eaacces error. We may need to roll this one back

@jarofghosts
Copy link
Contributor Author

EACCESS sounds like a permission problem, is it possible it's unrelated?

@chrismccord
Copy link
Member

Yes, but it works fine under the previous watcher configuration, so it's not unrelated. The previous watcher config that this replaced was added specifically to workaround some perm issues we had on windows

@jarofghosts
Copy link
Contributor Author

Ah, I'm sorry. I confirmed it working, but it was only on Windows 8, maybe there is some difference on different versions.

@chrismccord
Copy link
Member

yeah I believe you :) I'm not sure how prevalent the perm issue with be for windows with this change. Maybe an isolated case, but who knows

@josevalim
Copy link
Member

Don't forget to also revert #1270 then!

@chrismccord chrismccord mentioned this pull request Oct 29, 2015
Closed
josevalim pushed a commit that referenced this pull request Oct 29, 2015
Revert "Merge pull request #1273 from jarofghosts/brunch-watch-npm-sc…
6b203d9 
…ript"

This reverts commit 9c74379, reversing
changes made to bd1589a.
@rstacruz
Copy link
Contributor

EACCESS sounds like a permission problem

hypothesis: sounds like the kind of error you'd run into when the binstubs (node_modules/.bin) aren't made properly. maybe node_modules was copied over from an osx/linux installation?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jarofghosts @josevalim @chrismccord @rstacruz