Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace CI with GitHub Actions #3557

Closed
wants to merge 1 commit into from
Closed

Replace CI with GitHub Actions #3557

wants to merge 1 commit into from

Conversation

alexgaribay
Copy link
Member

No description provided.

@alexgaribay alexgaribay force-pushed the ag-ci-github-actions branch 30 times, most recently from 7931f2a to a8fd8c5 Compare September 20, 2019 16:49
@alexgaribay alexgaribay marked this pull request as ready for review September 20, 2019 16:57
@alexgaribay alexgaribay force-pushed the ag-ci-github-actions branch 7 times, most recently from bca975f to bd2c567 Compare March 19, 2020 18:49
ericmj
ericmj reviewed Mar 20, 2020
View reviewed changes
.github/workflows/ci.yml Outdated
strategy:
matrix:
elixir: ['1.7.4', '1.8.2', '1.9.4', '1.10.2']
cowboy: ['1', '2']
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't believe the elixir and cowboy settings in matrix does anything unless you also set the otp version. But they are not necessary since you also explicitly listed all versions in include.

Copy link
Member Author

@alexgaribay alexgaribay Mar 20, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I set the matrix values to match what's currently in Travis CI config. This was the only way I could configure Github Actions to test the specific versions for parity with Travis. The original PR was made months ago when Github Actions became available for everyone. If there's an easier way now to get a specific set of configurations, I'm all for suggestions.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, but you are duplicating the matrix values in the include listing. You don't need both.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ericmj Thanks for that. I don't remember Actions working that way originally but I'm glad it does now nonetheless.

@josevalim
Copy link
Member

Merged manually, thanks!

@josevalim josevalim closed this Aug 4, 2020
@josevalim josevalim deleted the ag-ci-github-actions branch August 4, 2020 15:34
@ma2gedev ma2gedev mentioned this pull request Dec 12, 2020
Closed
@dolfinus dolfinus mentioned this pull request Feb 14, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericmj ericmj ericmj left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alexgaribay @josevalim @ericmj