Add phx.new --live #3680
Merged
Add phx.new --live #3680
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… `phoenix_live_view`
…ngs LiveView into new phoenix app
chrismccord
commented
Feb 24, 2020
josevalim
reviewed
Feb 24, 2020
josevalim
reviewed
Feb 24, 2020
josevalim
reviewed
Feb 24, 2020
josevalim
reviewed
Feb 24, 2020
josevalim
reviewed
Feb 24, 2020
| longpoll: false | ||
| longpoll: false<%= if live do %> | ||
|
|
||
| socket "/live", Phoenix.LiveView.Socket, websocket: [connect_info: [session: @session_options]]<% end %> |
There was a problem hiding this comment.
Suggested change
| socket "/live", Phoenix.LiveView.Socket, websocket: [connect_info: [session: @session_options]]<% end %> | |
| socket "/live", Phoenix.LiveView.Socket, | |
| websocket: [connect_info: [session: @session_options]]<% end %> |
There was a problem hiding this comment.
This is what I had at first, but it failed --check-formatted and that pesky formatter wants it on ea single line :)
There was a problem hiding this comment.
Bump the Elixir version. Since V1.7 or V1.8 we respect the user choice in here.
josevalim
reviewed
Feb 24, 2020
josevalim
reviewed
Feb 24, 2020
josevalim
reviewed
Feb 24, 2020
josevalim
reviewed
Feb 24, 2020
josevalim
reviewed
Feb 24, 2020
josevalim
reviewed
Feb 24, 2020
josevalim
reviewed
Feb 24, 2020
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is based on the work @aforward started in #3376 (❤️) . All the setup and tests are in place so it's now a matter of determining what we want to go with naming wise and home page feature wise. I included a Modal component with the app, which is something our live CRUD generators could check for and add, but it would be nice to include it here if we can make it worthwhile. Currently I use the modal to show
hex.outdatedresults, but I think we can do better so consider this a starting point to explore from live home page wise.