Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Router scope macro. #39

Merged
merged 2 commits into from
Feb 12, 2014

Conversation

darkofabijan
Copy link
Contributor

Routes scoping discussed in #26.

I have doubts about nesting ResourcesContext and ScopeContext under Context.[Resources|Scope]. I would love to hear your feedback on this and everything else.

@chrismccord
Copy link
Member

I'm going through this locally and I don't have much to comment on as it looks really great. :)

I like the approach with the shared Stack module. My initial reaction too was that we could combine both contexts under Context.[Resources|Scope], but after going through the implementation, I agree keeping each context separate is the way to go. I have a few formatting tweaks to make, but it should land in master momentarily. Thanks!

@chrismccord chrismccord merged commit 2ee1544 into phoenixframework:master Feb 12, 2014
@darkofabijan darkofabijan deleted the routing-scopes branch February 15, 2014 18:44
Gazler pushed a commit to Gazler/phoenix that referenced this pull request Sep 17, 2015
…ction-explanation-to-controller-guide

Add plug action explanation to controller guide
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants