guides: Introduction section review #4499
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
milmazz
commented
Sep 25, 2021
| @@ -1,4 +1,4 @@ | |||
| # Introduction | |||
There was a problem hiding this comment.
Should I update the file path from guides/channels/channels.md to be something like guides/real-time/channels.md? Just to follow the pattern described in the sidebar.
There was a problem hiding this comment.
I would do so. As it's easier to find presence.md then.
But wait for some of the maintainers to approve this oppinion.
milmazz
changed the title
cw789
approved these changes
Sep 25, 2021
|
💚 💙 💜 💛 ❤️ |
|
Feel free to send a PR to rename the directory too! |
milmazz
added a commit
to milmazz/phoenix
that referenced
this pull request
Oct 1, 2021
The proposal to rename the directory comes from this [comment](phoenixframework#4499 (comment))
josevalim
pushed a commit
that referenced
this pull request
Oct 5, 2021
The proposal to rename the directory comes from this [comment](#4499 (comment))
chrismccord
pushed a commit
that referenced
this pull request
Oct 8, 2021
chrismccord
pushed a commit
that referenced
this pull request
Oct 8, 2021
The proposal to rename the directory comes from this [comment](#4499 (comment))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a few things in the "Introduction" guides: