Kill channels on WS transport terminate #796
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Closing against 3a60e42 :) |
Gazler
pushed a commit
that referenced
this pull request
Sep 6, 2017
* reference Redis adapter * remove sentence
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is just proof of concept to demo a fix for #795. Sadly, it doesn't matter what we return in the
ws_terminatemethod as cowboy's just going to kill us no matter what and call it a day. So, we need to send some sort of notification to the transport's open channels to notify them they should exit. I've hacked that by just having the VM do it for me ;)