Extract phx-feedback-for #3086
Closed
Extract phx-feedback-for #3086
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`phx-no-feedback` is a class that is added to elements with the `phx-feedback-for` attribute when the corresponding elements were not interacted with yet. The problem with the current approach is that LV of course removes the added class when the DOM is patched. Therefore we were relying on tracking all input elements on each patch to properly hide the feedback. This worked fine until the magicId optimization. Now, whole sections of the DOM could be skipped on a patch, not tracking inputs inside them and therefore not hiding feedback on the corresponding containers. This all was built before we had the `JS` module, which gives us a nice way to permanently apply classes to an element, even if it is patched. Using this functionality, we can now apply the `phx-no-feedback` class correctly when we first render the page. This way, we don't need remove the class on each patch, and we don't rely on tracking all inputs in dom_patch. When we then interact with the input, or submit the form, we show the feedback again as usual, removing the sticky class from the feedback containers. Fixes phoenixframework#3071.
We want to remove phx-feedback-for in LiveView 1.0 for a better solution. This commit extracts the phx-feedback-for into its own file that can be dropped in by users for backwards compatibility. Relates to phoenixframework#3084
SteffenDE
force-pushed
the
extract_feedback
branch
2 times, most recently
from
0ea80b8
to
9909010
Compare
remove no-feedback class when phx-feedback-for is removed
SteffenDE
force-pushed
the
extract_feedback
branch
from
9909010
to
6adff16
Compare
|
Will revisit when |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR extends #3084 and moves the phx-feedback-for functionality into its own file.
Relates to #3084.
Fixes #3071.