use other selector syntax in by_id (fixes #3144)

[SteffenDE]

Fixes #3144

[SteffenDE]

Waiting for philss/floki#548.

[philss]

@SteffenDE the new feature (from your PR) is available in Floki v0.36 now :)

[SteffenDE]

@josevalim I added a TODO to change by_id! as well, but I'm not sure because the current implementation raises when multiple elements are found, while Floki.get_by_id/2 just returns the first one:

phoenix_live_view/lib/phoenix_live_view/test/dom.ex

Lines 43 to 46 in e66beb6

	many ->
	{:error, :many,
	"expected #{type} #{inspect(selector)} to return a single element, " <>
	"but got #{length(many)}: \n\n" <> inspect_html(many)}

Let me know what you think.

[josevalim]

So ironically we also needed a find_by_id? :D I am fine with dropping the by_id! but maybe we should get @chrismccord's opinion.

[SteffenDE]

There's one test that relies on it:

  1) test raises on duplicate child LiveView id (Phoenix.LiveView.NestedTest)
     test/phoenix_live_view/integrations/nested_test.exs:137
     Expected to catch exit, got nothing
     code: assert Exception.format(:exit, catch_exit(render(view))) =~
     stacktrace:
       test/phoenix_live_view/integrations/nested_test.exs:147: (test)

[josevalim]

Yeah, we would have to nuke it, but that’s fine. We do the check for the users convenience.

[josevalim]

💚 💙 💜 💛 ❤️