Rename first adapter in the pool for backwards compatability #169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pubsub v2.0 expects there to be a single process for the process group named `Elixir.my_pubsub.Adapter`. v2.1 added pools, which means that the processes are supervised with a supervisor called `Elixir.my_pubsub.Adapter` along with n processes named `Elixir.my_pubsub.Adapter_n` where n is the pool size. This commit changes the supervisor name to `Elixir.my_pubsub.Adapter_supervisor` and renames pool item 1 to be `Elixir.my_pubsub.Adapter`. This will allow backwards compatability with v2.0 when the pool size is set to 1.
josevalim
approved these changes
Apr 5, 2022
|
Thanks. I will cut a new 2.1.1. This also closes #168 ❤️❤️❤️🐥🔥 |
arkgil
added a commit
to Whatnot-Inc/phoenix_pubsub
that referenced
this pull request
Oct 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pubsub v2.0 expects there to be a single process for the process group
named
Elixir.my_pubsub.Adapter.v2.1 added pools, which means that the processes are supervised with a
supervisor called
Elixir.my_pubsub.Adapteralong with n processesnamed
Elixir.my_pubsub.Adapter_nwhere n is the pool size.This commit changes the supervisor name to
Elixir.my_pubsub.Adapter_supervisorand renames pool item 1 to be
Elixir.my_pubsub.Adapter. This willallow backwards compatability with v2.0 when the pool size is set to 1.