Add support for union types with inheritance #298
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently union type interpreter generates code correctly only if union types don't extend other user-defined types.
For example let's look at the schema used for a unit test
If I change Phone and Notebook types to extend another custom type
Interpreter ignores Phone/Notebook types and Device POJO looks like this:
This PR contains a fix for this behavior, I believe expected result is similar to
Could you please review it and maybe propose a better solution?