New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement - Led, Vibration Pattern, Priority on Android #105

Closed
alexislg2 opened this Issue Sep 5, 2015 · 7 comments

Comments

Projects
None yet
4 participants
@alexislg2
Contributor

alexislg2 commented Sep 5, 2015

Hey,
I could write a PR for supporting following:

  • send a Led Color
  • send a vibration pattern
  • send priority (from 0 to 2)

For Android only of course. Interested?

@alexislg2 alexislg2 changed the title from Enhancement to Enhancement - Led, Vibration Pattern, Priority on Android Sep 5, 2015

@macdonst macdonst added the enhancement label Sep 6, 2015

@macdonst

This comment has been minimized.

Show comment
Hide comment
@macdonst

macdonst Sep 6, 2015

Member

@alexislg2 Yes, please do.

Member

macdonst commented Sep 6, 2015

@alexislg2 Yes, please do.

@macdonst

This comment has been minimized.

Show comment
Hide comment
@macdonst

macdonst Sep 7, 2015

Member

I'm reopening until I get a chance to merge your PR.

Member

macdonst commented Sep 7, 2015

I'm reopening until I get a chance to merge your PR.

@macdonst macdonst reopened this Sep 7, 2015

@macdonst

This comment has been minimized.

Show comment
Hide comment
@macdonst

macdonst Sep 13, 2015

Member

@alexislg2 re-test with the upcoming 1.3.0 release and re-open if it doesn't fix your issue.

Member

macdonst commented Sep 13, 2015

@alexislg2 re-test with the upcoming 1.3.0 release and re-open if it doesn't fix your issue.

@macdonst macdonst closed this Sep 13, 2015

@ezequielrozen

This comment has been minimized.

Show comment
Hide comment
@ezequielrozen

ezequielrozen Sep 22, 2015

@macdonst Hi, I'm making a push notification with node-gcm, and I don't know how to turn on the led in the phone. I tried as you showed in the example but it didn't work. Please can you tell me the way?

Thanks!

@macdonst Hi, I'm making a push notification with node-gcm, and I don't know how to turn on the led in the phone. I tried as you showed in the example but it didn't work. Please can you tell me the way?

Thanks!

@fredgalvao

This comment has been minimized.

Show comment
Hide comment
@fredgalvao

fredgalvao Sep 22, 2015

Collaborator

What device are you testing on?

Direct quote from android docs on [notificationBuilder.setLights](http://developer.android.com/reference/android/app/Notification.Builder.html#setLights%28int, int, int%29):

Not all devices will honor all (or even any) of these values.

Collaborator

fredgalvao commented Sep 22, 2015

What device are you testing on?

Direct quote from android docs on [notificationBuilder.setLights](http://developer.android.com/reference/android/app/Notification.Builder.html#setLights%28int, int, int%29):

Not all devices will honor all (or even any) of these values.

@ezequielrozen

This comment has been minimized.

Show comment
Hide comment
@ezequielrozen

ezequielrozen Sep 22, 2015

@fredgalvao I just saw that there is a new release with the fix, but now I'm having this problem: #159

@fredgalvao I just saw that there is a new release with the fix, but now I'm having this problem: #159

@lock

This comment has been minimized.

Show comment
Hide comment
@lock

lock bot Jun 5, 2018

This thread has been automatically locked.

lock bot commented Jun 5, 2018

This thread has been automatically locked.

@lock lock bot locked as resolved and limited conversation to collaborators Jun 5, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.