Skip to content
This repository has been archived by the owner on Sep 4, 2020. It is now read-only.

Enhancement - Led, Vibration Pattern, Priority on Android #105

Closed
alexislg2 opened this issue Sep 5, 2015 · 7 comments
Closed

Enhancement - Led, Vibration Pattern, Priority on Android #105

alexislg2 opened this issue Sep 5, 2015 · 7 comments

Comments

@alexislg2
Copy link
Contributor

Hey,
I could write a PR for supporting following:

  • send a Led Color
  • send a vibration pattern
  • send priority (from 0 to 2)

For Android only of course. Interested?

@alexislg2 alexislg2 changed the title Enhancement Enhancement - Led, Vibration Pattern, Priority on Android Sep 5, 2015
@macdonst
Copy link
Member

macdonst commented Sep 6, 2015

@alexislg2 Yes, please do.

@macdonst
Copy link
Member

macdonst commented Sep 7, 2015

I'm reopening until I get a chance to merge your PR.

@macdonst macdonst reopened this Sep 7, 2015
macdonst pushed a commit that referenced this issue Sep 11, 2015
@macdonst
Copy link
Member

@alexislg2 re-test with the upcoming 1.3.0 release and re-open if it doesn't fix your issue.

@ezequielrozen
Copy link

@macdonst Hi, I'm making a push notification with node-gcm, and I don't know how to turn on the led in the phone. I tried as you showed in the example but it didn't work. Please can you tell me the way?

Thanks!

@fredgalvao
Copy link
Collaborator

What device are you testing on?

Direct quote from android docs on [notificationBuilder.setLights](http://developer.android.com/reference/android/app/Notification.Builder.html#setLights%28int, int, int%29):

Not all devices will honor all (or even any) of these values.

@ezequielrozen
Copy link

@fredgalvao I just saw that there is a new release with the fix, but now I'm having this problem: #159

@lock
Copy link

lock bot commented Jun 5, 2018

This thread has been automatically locked.

@lock lock bot locked as resolved and limited conversation to collaborators Jun 5, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Development

No branches or pull requests

4 participants