New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notification callback for pushes without a message #80

Closed
iggyfisk opened this Issue Aug 27, 2015 · 3 comments

Comments

Projects
None yet
2 participants
@iggyfisk

My service relies on a few push notifications without a message but with a payload, which means they'll be invisible when the app is in background mode but can be used in foreground mode to trigger a server refresh etc. This worked perfectly in the deprecated PushPlugin, but now I'm foiled by
else if (result && typeof result.message !== 'undefined')
in push.js. Any chance we could check for additionalData / trigger some other event instead for "empty" notifications?

@macdonst macdonst added the bug label Aug 27, 2015

@macdonst

This comment has been minimized.

Show comment
Hide comment
@macdonst

macdonst Aug 27, 2015

Member

@iggyfisk kk, I'll get a 1.2.1 out as soon as I can to fix the problem. It's actually a pretty trivial change.

Member

macdonst commented Aug 27, 2015

@iggyfisk kk, I'll get a 1.2.1 out as soon as I can to fix the problem. It's actually a pretty trivial change.

@macdonst

This comment has been minimized.

Show comment
Hide comment
@macdonst

macdonst Aug 31, 2015

Member

@iggyfisk fixed in master, 1.2.1 should be out soon.

Member

macdonst commented Aug 31, 2015

@iggyfisk fixed in master, 1.2.1 should be out soon.

@lock

This comment has been minimized.

Show comment
Hide comment
@lock

lock bot Jun 5, 2018

This thread has been automatically locked.

lock bot commented Jun 5, 2018

This thread has been automatically locked.

@lock lock bot locked as resolved and limited conversation to collaborators Jun 5, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.