Skip to content
This repository has been archived by the owner on Nov 6, 2019. It is now read-only.

TODO for 1.0 #50

Closed
24 of 27 tasks
sccolbert opened this issue May 22, 2016 · 26 comments
Closed
24 of 27 tasks

TODO for 1.0 #50

sccolbert opened this issue May 22, 2016 · 26 comments

Comments

@sccolbert
Copy link
Member

sccolbert commented May 22, 2016

This is a list of things which need to be done before 1.0 release. Will add to list as I find things.

  • Rename text -> label where relevant
  • Rename tooltip -> caption where relevant
  • Ensure docstring example import paths are correct
  • Reasonably complete test suite
  • Maximize support for dock panels
  • Tear out window support for dock panels
  • Flat widget hierarchy for dock panel (solves iframe issue and IE/Edge relayout issues)
  • Allow a non-global instance of command registry and keymap manager to be used where relevant
  • Tests for core/mimedata
  • Tests for dom/dragdrop
  • Audit import paths in doc string examples.
  • Vector method conveniences: popAt, remove, removeAt
  • Audit onActivateRequest implementation for each widget
  • More specific node types on widgets and renderers
  • Better return values for removeTab, removeItem, etc.
  • TabPanel should activate the widget when its tab is clicked, even if its already the current widget.
  • Application, DI, phosphide stuff
  • Animated dock overlays
  • Investigate using <a> tags inside things like tabs, command items, and sidebar buttons.
  • Use this for sender type of ISignal objects.
  • Update content renderers to use vdom.
  • Audit BoxSizer usage to ensure that minSize >= maxSize at all usage points.
  • Layout options should not be optional. The panel should provide the defaults.
  • Should the split layout handle events for the split panel?
  • Audit dispose methods on layouts (some may be missing).
  • Audit everything for potential use of readonly.
  • Add !important for CSS hidden rules where appropriate.
@sccolbert
Copy link
Member Author

ping @afshin @blink1073

Add comments when you come across things which should be added to this list

@jasongrout
Copy link
Member

phosphor-core paths in docs need to be changed to the correct path now: https://github.com/phosphorjs/phosphor/search?utf8=%E2%9C%93&q=phosphor-core

@vrmerlin
Copy link

Hi folks -- can we get an update on the approximate timeline for 1.0? We are hoping to use Phosphor for a large UI project, and particularly need the ability to tear off (and return) windows from the docker.

Thanks,
John

@mladen107
Copy link

mladen107 commented Aug 12, 2016

Hello, I have same question. In next few months I will need to start working on huge desktop like application. Phosphor would help a lot on this.

@afshin
Copy link
Member

afshin commented Aug 12, 2016

@vrmerlin @mladen107 I don't know the specific date for 1.0, but I can tell you that the 0.6.x milestone which has already been released is what we are using to build JupyterLab, and we believe it is ready for use in a large, complex application.

Maybe @sccolbert can fill you in on the projected timetable.

@vrmerlin
Copy link

I would agree from my experimentation that the library is very good as it is. I guess I'm asking because I particularly need the ability to tear off (and return) windows from the docker. My understanding is that that feature is still under development but planned for 1.0.

@afshin
Copy link
Member

afshin commented Aug 12, 2016

@vrmerlin Are you talking about creating new browser windows? Or do you just mean tearing off tabs from a DockPanel and moving them around?

If you're talking about new windows (i.e., native browser windows), you're right that you cannot currently do that. But if you're talking about within a single window, the current version can support that.

@vrmerlin
Copy link

I'd like to be able to click a button on a docked panel and have it become it's own window on the screen. A button should be provided to allow it to be easily snapped back in. You can do this with Golden Layout:

https://www.golden-layout.com

@sccolbert
Copy link
Member Author

@vrmerlin Yep, that's in the plans.

@sccolbert
Copy link
Member Author

Will probably be available before 1.0. This list is just things that I consider must have for a 1.0 release.

@vrmerlin
Copy link

That's great to hear, but I'm trying to understand if the feature is a few days or weeks away, or many months. I'm interested in a time frame so I can plan accordingly for our project, and let the review team know in our upcoming design review .

@sccolbert
Copy link
Member Author

sccolbert commented Aug 12, 2016

greater than 1 month and less than many months (sorry that I can't be more specific)

At the same time I add that functionality, I'll also the maximize-within-area functionality.

@vrmerlin
Copy link

Ok, thanks!

On Aug 12, 2016 9:28 AM, "S. Chris Colbert" notifications@github.com wrote:

1 month and < many months (sorry that I can't be more specific)

At the same time I add that functionality, I'll also the maximize-within-area functionality.

You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com//issues/50#issuecomment-239493356, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AHZXIkkTL_Y6CqOK2j6t59czXthwTxBCks5qfJ8RgaJpZM4IkG0z.

@vrmerlin
Copy link

Can we get an update on the progress and expected timeline towards 1.0? It's been 3 months since any code was modified.

@blink1073
Copy link
Member

@vrmerlin, #178 is where the bulk of our work has been.

@sccolbert
Copy link
Member Author

sccolbert commented Jan 25, 2017

@vrmerlin I don't do big updates or changes on master, so be sure to check the other branches before drawing any conclusions as to activity ;)

1.0 should be ready soon.

@vrmerlin
Copy link

Oh, great, thanks!

@sccolbert
Copy link
Member Author

maximize and popup dock panels will be post 1.0. Closing this as complete modulo tests.

@blink1073
Copy link
Member

🎉

@vrmerlin
Copy link

Darn, I had the impression back in August that the pop-out panels were coming very soon. This was a very important feature to us. I'm thrilled to see that 1.0 is being finalized, but it's a big loss for us to not have that capability.

@sccolbert
Copy link
Member Author

@vrmerlin Don't worry, it's still coming as the next feature I work on. I'm just moving it to a feature release so other vested users can start updating their code.

@rmeshksar
Copy link

@sccolbert . First of all thank you very much for the great work.
I am also in need of pop-out panels feature. Is there any timeline for this feature? is there any workaround for now?
thanks.

@sccolbert
Copy link
Member Author

I think we decided on not making it a built-in feature of the DockPanel, but rather create a separate FloatingWindow widget (or something like that) to which you could add your content widget. Then let the application author decide how they want to allow the user to create floating windows.

@rmeshksar
Copy link

Does is make it possible to dock and un-dock the window to the DockPanel?

@sccolbert
Copy link
Member Author

It would yes. You can remove any widget from anything by moving it (programmatically) to a different parent widget.

@rmeshksar
Copy link

That's great. Looking forward to this feature.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants