Feature dockpanel refactor #155

sccolbert · 2016-11-03T02:29:10Z

The API is largely the same.

Summary of breaking changes:

The layout-changed message has been replaced by an explicit call to layout.init().
EmptyIterator.instance is replaced with empty() for consistency with other iterators.
Removed the deactivate-request message and related methods/handlers.
Made removeWidget an abstract method on Layout.
The showOverlay and findDropTarget methods of DockPanel are now private.
The zone property of the IOverlayGeometry interface has been removed.

Summary of additions:

New iterators: once, repeat, and chain.
Acontains iterator search function.
Public functionality in the box engine for adjusting a sizer.
Added the tabActivateRequested signal to TabBar.
New DockLayout class.
The DockPanel now accepts an IRenderer for creating tab bars and handles.
There are new methods on DockPanel for creating iterators over widgets, tab bars, and handles.

Summary of behavioral changes:

There is now a drop zone on top of the tab bars.
There is no more center drop zone on a widget.
You must hold shift while dragging to activate the border drop zones.
Clicking on a tab now activates the widget, even if the tab is already current.

Summary of style-related changes:

The DockPanel is now flat. It has four subcontrols: p-DockPanel-tabBar, p-DockPanel-widget, p-DockPanel-handle, and p-DockPanel-overlay.
The old subcontrols p-DockPanel-tabPanel and p-DockPanel-splitPanel are gone.

blink1073

Review of all but the main dock panel file.

blink1073 · 2016-11-03T11:29:01Z

example/index.ts

@@ -321,6 +330,8 @@ function main(): void {

  Widget.attach(bar, document.body);
  Widget.attach(main, document.body);
+
+  (window as any).dock = dock;


Is this intentionally left in?

blink1073 · 2016-11-03T11:41:36Z

src/ui/splitpanel.ts

@@ -617,6 +610,7 @@ class SplitLayout extends PanelLayout {
    if (this.parent) this.parent.update();
  }

+  // TODO rename this to `moveHandle`


Are these TODOs intended for another PR?

blink1073 · 2016-11-03T11:41:42Z

src/ui/splitpanel.ts

@@ -655,21 +649,26 @@ class SplitLayout extends PanelLayout {

    // Prevent widget resizing unless needed.
    each(this._sizers, sizer => {
+      // TODO is this check actually necessary?


blink1073 · 2016-11-03T11:44:39Z

src/ui/tabbar.ts

+   *
+   * This signal is emitted even if the clicked tab is the current tab.
+   */
+  tabActivateRequested: ISignal<TabBar, TabBar.ITabActivateRequestedArgs>;


If this signal also contained the original event (or at least the button and the client position), we could use it for #104.

I'm trying to avoid emitting events as signals. The signal should have semantic meaning, rather than eventful meaning.

afshin · 2016-11-03T12:58:58Z

src/ui/panel.ts

+  protected init(): void {
+    super.init();
+    let index = 0;
+    each(this, widget => { this.attachWidget(index++, widget); });


Why did you choose not to use enumerate here? Performance?

afshin · 2016-11-03T13:03:04Z

test/src/ui/panel.spec.ts

-        expect(layout.removeWidgetAt(0)).to.be(widget);
+        let layout = new LogPanelLayout();
+        widget.layout = layout;
+        expect(layout.methods.indexOf('init')).to.not.be(-1);


expect(layout.methods).to.contain('init'); reads a little nicer.

afshin · 2016-11-03T13:03:17Z

test/src/ui/panel.spec.ts

+        let widgets = [new LogWidget(), new LogWidget(), new LogWidget()];
+        each(widgets, w => { layout.addWidget(w); });
+        parent.layout = layout;
+        expect(layout.methods.indexOf('init')).to.not.be(-1);


Ditto for this one and a few more.

will save test cleanup for another PR

jasongrout · 2016-11-03T20:39:19Z

There is no more center drop zone on a widget.

I was just getting used to this. VS Code is nice in that it lets you either drag to a tab bar or drag to the middle. I've noticed it feels quite a bit faster to drag to the middle (once I got used to it...)

sccolbert added 30 commits September 19, 2016 12:24

add chain iterator

fd1be87

wip

3811a3c

update to TS 2.0 final

07920ed

use an internal index in chain iterator

b25d032

add a repeat iterator

fc93190

remove return values from panel remove methods

db5c39b

make removeWidget a formal Layout method

7858fcc

remove 'layout-changed' message in preference for explicit layout init()

3d0778d

cleanup

6e2b4d6

fix doc typo

9386290

consume an iterator of iterators in the ChainIterator

adf0dee

wip

25f1ad9

wip

8e83295

wip

ed630b6

wip

b4982b4

finish removal method

8159ef1

docs

0da0fc5

wip

d34efa9

update EmptyIterator to be consistent with other iterator usage

b821298

add a once convenience iterator

6dd0a25

add a contains search function

f379ac7

add indexOf and lastIndexOf to Vector

af92af6

code cleanup

f6684b6

wip

83e1416

work around flicker on edge when show/hide children

863d758

add a flag for Edge user agent

ad347a4

prevent flicker on edge

b6c8ff7

fill in removeWidget method

488a332

cleanup

118b2af

cleanup imports

d9fdfac

sccolbert added 17 commits October 26, 2016 17:59

wip

4f922b7

docs

02c7e16

hold sizes during widget remove

aade91f

code ordering

55669bc

cleanup

7faa44a

add a class name to a dockpanel drag tab

dec68f2

handle insert ratios

756007f

add activation method

3757857

hold off on collections changes for another PR

623c334

add the internal focus tracker

3940a67

activate the dropped widget

99e15bc

cleanup

d7e0ac0

cleanup

7a70941

remove extra class name from drag image

053edd2

update example

04de4f7

remove scratch file

22262ae

fix tests

6874980

blink1073 reviewed Nov 3, 2016

View reviewed changes

doc typo

56f4a2c

afshin approved these changes Nov 3, 2016

View reviewed changes

sccolbert added 4 commits November 3, 2016 11:21

formatting

624679b

handle deep cloning of inner iterators

b142dcd

add tests for new iterators

a8fde7f

remove debug codE

8ae0c11

blink1073 approved these changes Nov 3, 2016

View reviewed changes

sccolbert merged commit bf3a069 into master Nov 3, 2016

blink1073 mentioned this pull request Nov 4, 2016

Upgrade to phosphor 0.7 jupyterlab/jupyterlab#1215

Merged

1 task

ellisonbg mentioned this pull request Nov 4, 2016

Latest Dockpanel behavior #159

Closed

sccolbert deleted the feature-dockpanel-refactor branch February 15, 2017 02:59

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feature dockpanel refactor #155

Feature dockpanel refactor #155

sccolbert commented Nov 3, 2016 •

edited

blink1073 left a comment

blink1073 Nov 3, 2016

sccolbert Nov 3, 2016

blink1073 Nov 3, 2016

sccolbert Nov 3, 2016

blink1073 Nov 3, 2016

sccolbert Nov 3, 2016

blink1073 Nov 3, 2016

sccolbert Nov 3, 2016

afshin Nov 3, 2016

sccolbert Nov 3, 2016

afshin Nov 3, 2016

afshin Nov 3, 2016

sccolbert Nov 3, 2016

jasongrout commented Nov 3, 2016

Feature dockpanel refactor #155

Feature dockpanel refactor #155

Conversation

sccolbert commented Nov 3, 2016 • edited

blink1073 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jasongrout commented Nov 3, 2016

sccolbert commented Nov 3, 2016 •

edited