Lower maximum number of transfers in mintMany

photochain · Sep 29, 2018 · 8663a0c · 8663a0c
1 parent 96f877c
commit 8663a0c
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 5 deletions.
diff --git a/scripts/distribute.ts b/scripts/distribute.ts
@@ -79,7 +79,7 @@ async function deployVestingContract(token: PhotochainToken, beneficiary: Addres
 }
 
 class TransactionAggregator {
-    private static readonly MAX_MINT_MANY = 200;
+    private static readonly MAX = 168;
 
     private txs: Array<Promise<TransactionResult>> = [];
     private addresses: Address[] = [];
@@ -95,7 +95,7 @@ class TransactionAggregator {
         this.addresses.push(beneficiary);
         this.amounts.push(amount);
 
-        if (this.addresses.length >= TransactionAggregator.MAX_MINT_MANY) {
+        if (this.addresses.length >= TransactionAggregator.MAX) {
             this.mintAggregated();
         }
     }

diff --git a/test/photochaintoken.test.ts b/test/photochaintoken.test.ts
@@ -439,8 +439,8 @@ contract('PhotochainToken', accounts => {
             }
         });
 
-        const maxMintMany = 200;
-        it(`should accept ${maxMintMany} beneficiaries at once`, async () => {
+        const maxMintMany = 168;
+        it(`should accept ${maxMintMany} beneficiaries at once and keep gas usage under 5.3 mln`, async () => {
             const prevSupply = await token.totalSupply();
 
             const beneficiaries = [];
@@ -456,7 +456,9 @@ contract('PhotochainToken', accounts => {
             }
             const totalAmount = amounts.reduce((a: BigNumber, b: BigNumber) => a.add(b), new BigNumber(0));
 
-            await token.mintMany(beneficiaries, amounts);
+            const tx = await token.mintMany(beneficiaries, amounts);
+
+            assert.isBelow(tx.receipt.gasUsed, 5_300_000);
 
             // check total supply change to confirm the transaction has succeeded
             assertPhtEqual(await token.totalSupply(), prevSupply.add(totalAmount));