Fix face and object recognition of rotated images #334
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uraid
changed the title
|
Edit: Found it affects also the object recognition, so added a commit to fix it as well. |
damianmoore
approved these changes
Sep 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed that most of the selfie images don't have any faces recognized.
Had a hunch it's metadata related.
Took a look and found those have orientation exif tag attached, so are rotated 270 degrees.
Poked around the code and found that thumbnails are rotated correctly, but no pre-processing is made on the face recognition side.
Added the thumbnail rotation correction code to the face recognition model.
Reprocessed those selfie images and validated it fixes the issue.
Just wanted to contribute to this amazing project! :)
Thank you for your hard work!