Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UX: Improve touch event accuracy #1048

Closed
andrewlow opened this issue Feb 15, 2021 · 17 comments
Closed

UX: Improve touch event accuracy #1048

andrewlow opened this issue Feb 15, 2021 · 17 comments
Assignees
Labels
idea Feedback wanted / feature request released Available in the stable release

Comments

@andrewlow
Copy link

To mark a photo as a favorite - you need to click on the heart

Consider the mosaic view:
https://demo.photoprism.org/browse?view=mosaic&order=added&public=true&quality=3

image

On a mobile device - the size of the tiles is quite small - and hitting the heart (favorite) is very very easy. This is due to the fact that in order to scroll the screen, you have to touch the screen.

There should be accommodations made when displaying to a mobile sized device OR it should be a more specific gesture on a touch screen device to click the heart. I'd even accept making it only a multi-select context menu option - but understand that would be annoying if you just wanted to tag something once.

Anyone using a mobile phone or small format table to view photos (especially in mosaic view) will certainly accidentally favorite photos they did not mean to.

@andrewlow
Copy link
Author

Wow.. I searched for similar issues - but clearly not hard enough. This PR seems related #962

@lastzero
Copy link
Member

We've already made accommodations and put work into this but can't only focus on touch UX or video transcoding for the next two months - should be good enough for now. Will come back to this once Facial Recognition #22 is implemented.

@lastzero
Copy link
Member

Don't even have time to completely test #962 on iOS and Android - you're welcome to help out 👍

@lastzero lastzero added the idea Feedback wanted / feature request label Feb 15, 2021
@JamesSwift
Copy link

As a former web developer, when I use PP on mobile something just feels off about the way actions are triggered. I haven't used the vuetify/vue framework before, but I'm wondering what event the buttons (heart/select/view) are listening on. If they were on click you shouldn't get this behavior as the browser filters out swipe/scroll events. I tried to work it out both via the source code and using the inspector, but the obfuscation of the templating language defeated me. It appears they are listening on touch events for some reason. Perhaps someone with experience with the framework could shed some light?

@lastzero
Copy link
Member

It was click but didn't work with iOS. See related issue.

@streiman
Copy link

streiman commented Mar 17, 2021

I just want to support the idea, that there should be some fixes to the mobile UI. On my Huawei P20pro it is almost impossible to scroll the pictures. Either I accidently make them a favorite or I open the picture or video. That is eapecially sad because there is no fully featured app.

I understand that there are many other improvements to work on, but many people view their pictures mostly on their phone. I have shown PhotoPrism to different people and most were impressed about the speed ("feels faster then Google Photos when showing pictures") but told me that they think it is not working well on their phone.

I think it would help as a workaround to hide the favorite heart button on mobile devices (at least as an option like "simple interface") and if it is not possible to make "clicking" pictures less sensitive only showing them in full size or playing the video if you longpress or double touch the thumbnail. I don't think that this is a perfect solution, but it would make the mobile view more usable for more people and might to be implemented without too much hazle.

@pseudorandomnumber
Copy link

Scrolling would work better if liking, selecting and opening pictures only happens after not registering a scroll event for about 100ms.
I don't understand, why facial recognition is the priority, when the UI is bacically not usable on Touchscreens.

@lastzero
Copy link
Member

Dear @pseudorandomnumber: The UI is usable on touch screens, but needs more tweaking to avoid accidental likes on some devices. We've already spent a significant amount of time with that and even bought an iPad for specifically optimizing this - even though our funding goal is not reached by far.

In fact, our first priority is funding which is also why I wasn't able to perform much development last month. The more sponsors there are, the faster you get features and UX improvements. Thank you very much! ❤️

@lastzero
Copy link
Member

@streiman I'm using a Huawei P30 and have no major issues. We sadly had to go for a more low level event implementation as otherwise there are issues with newer iOS devices. Before that change, accidental liking wasn't an issue on Android but iOS wasn't properly usable. We do our best to further improve this as soon as possible. You're welcome to help us by testing this pull request: #962

@streiman
Copy link

@lastzero I would be more than happy to test it, but I have to confess I don't know how to install this version. I installed pp via docker-compose.

@lastzero
Copy link
Member

No worries then, we'll get to it eventually :)

@streiman
Copy link

I have to say it works like a charme on iPhone. I am little bit confused that it is so bad on my p20pro but ok on your p30. Do you use Chrome or something else I might try?

@lastzero
Copy link
Member

I'm using Chrome on EMUI 11 / Android 10.

@lastzero lastzero self-assigned this Apr 19, 2021
@lastzero lastzero added the please-test Ready for acceptance test label Apr 19, 2021
@lastzero
Copy link
Member

lastzero commented Apr 19, 2021

Event handlers now test if the finger was moved while touching, so that actions should not get triggered accidentally anymore. The new event handlers are not yet in place for albums, labels & list views. We can use them there too if the implementation works for you. It's going to be deployed to our demo for testing soon.

@streiman
Copy link

Much, much better experience. Thank you! Now it is really nice to scroll down my pictures on my smartphone :-)

@lastzero
Copy link
Member

Excellent, thanks for testing! I'm going to refactor albums & labels next.

@lastzero
Copy link
Member

Started a new preview build, available for testing on demo.photoprism.org soon:
https://drone.photoprism.app/photoprism/photoprism/1235

@lastzero lastzero changed the title When using touch screen (in mosaic view) liking (heart) a photo is too easy UX: Improve touch event accuracy Apr 22, 2021
@graciousgrey graciousgrey added released Available in the stable release and removed please-test Ready for acceptance test labels Apr 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
idea Feedback wanted / feature request released Available in the stable release
Projects
Status: Release 🌈
Development

No branches or pull requests

7 participants
@lastzero @JamesSwift @andrewlow @graciousgrey @pseudorandomnumber @streiman and others