Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RAW: Add RawTherapee flag to use existing sidecar files #1267

Closed
rizmot opened this issue May 5, 2021 · 7 comments
Closed

RAW: Add RawTherapee flag to use existing sidecar files #1267

rizmot opened this issue May 5, 2021 · 7 comments
Assignees
Labels
idea Feedback wanted / feature request released Available in the stable release

Comments

@rizmot
Copy link

rizmot commented May 5, 2021

Currently, RawTherapee ignores pre-existing sidecar-profiles. This can be changed using the -s command-line parameter according to https://rawpedia.rawtherapee.com/Command-Line_Options#RawTherapee_CLI

True, I didn't add / change any RawTherapee parameters. From what I remember, the standard profile is used by default. Probably need to modify the command to use other profiles / sidecars. Is there a generic way to do this or do we need to add yet another config parameter to set a profile name / type?

So i tested the following command: rawtherapee-cli -d -p raw.pp3 -s -o output.jpg -c input.RAW
This will use the default ( -d ) profile, then if another profile is specified ( -p raw.pp3 ) it will be stacked on top of the default profile. Then, if the -s command is set, a sidecar-profile, if one is found, will be stacked on top of whatever was specified before. The -d -p -s parameters have to be set in the right order since the last one will overwrite the ones before. As I understand it, -d and -p raw.pp3 might be optional in this case. So rawtherapee-cli -s -o output.jpg -c input.RAW should do the trick.

Originally posted by @rizmot in #1245 (comment)

@graciousgrey graciousgrey added idea Feedback wanted / feature request unfunded labels May 5, 2021
@lastzero lastzero self-assigned this May 23, 2021
@lastzero lastzero added please-test Ready for acceptance test and removed unfunded labels May 23, 2021
@lastzero lastzero changed the title RawTherapee: Implement -s parameter to process RAWs with pre-existing profiles if any are found. RAW: Add command flag so that RawTherapee uses existing sidecar files May 23, 2021
@lastzero
Copy link
Member

@rizmot Started a new preview build with this: https://drone.photoprism.app/photoprism/photoprism/1374

Can you test it please? If it works, we're going to release next week.

@lastzero lastzero changed the title RAW: Add command flag so that RawTherapee uses existing sidecar files RAW: Add RawTherapee flag to use existing sidecar files May 23, 2021
@lastzero
Copy link
Member

Updated Release Notes: https://docs.photoprism.org/release-notes/

@lastzero lastzero added released Available in the stable release and removed please-test Ready for acceptance test labels May 23, 2021
@lastzero
Copy link
Member

Already released it, hopefully it works for you as expected. At least it didn't seem to break anything. CR3 files still work.

@rizmot
Copy link
Author

rizmot commented May 24, 2021

@rizmot Started a new preview build with this: https://drone.photoprism.app/photoprism/photoprism/1374

Can you test it please? If it works, we're going to release next week.

I tested it and it works fine. Pre-existing profiles are now used for RAW-Processing with RawTherapee. Thank you.

@lastzero
Copy link
Member

Excellent, thanks for testing! 🙏

@louwers
Copy link

louwers commented Dec 12, 2021

I can't seem to get this to work. The JPG output does not match that of Rawtherapee. The .pp3 sidecar file is present and visible as one of the files:

image

I've disabled Darktable to ensure RAW processing is done by Rawtherapee:

image

I've also tried re-indexing to no avail.

Is there anything else I need to do to set this up?

@lastzero
Copy link
Member

@louwers Sorry for the late reply! If Darktable is found and not disabled/blacklisted, it is used by default. So I guess that the files were not converted with RawTherapee?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
idea Feedback wanted / feature request released Available in the stable release
Projects
Status: Release 🌈
Development

No branches or pull requests

4 participants