Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Photo Viewer: Searching then browsing shows the wrong images #1343

Closed
darkenbula opened this issue Jun 1, 2021 · 8 comments
Closed

Photo Viewer: Searching then browsing shows the wrong images #1343

darkenbula opened this issue Jun 1, 2021 · 8 comments
Assignees
Labels
bug Something isn't working released Available in the stable release

Comments

@darkenbula
Copy link

If i perform a search across my library for something like 'cat' for example, the search will return expected results of cat pictures. If i click on the first picture to view it and then use the right arrow i would expect it to cycle through the search results. Instead it will browser by date, so if the first returned search result is from march 6, using the right arrow to move to the next photo will cycle in reverse order through pictures from that date.

@lastzero
Copy link
Member

lastzero commented Jun 1, 2021

Interesting, maybe this goes somehow back in your browser history?

@darkenbula
Copy link
Author

I get the same results in a new private browser window. Results seem inconsistent. For example i sort my search results from oldest to newest it behaves as expected, if i then display search results from newest to oldest, doesnt work correctly

@darkenbula
Copy link
Author

You will notice in the video below, the images that are browsed, don't match the search results

https://youtu.be/IClAsEZFccc

@guim31
Copy link

guim31 commented Jun 1, 2021

I face the exact same issue (docker install on my Unraid server)

@darkenbula
Copy link
Author

docker install on unraid here as well

@lastzero
Copy link
Member

lastzero commented Jun 1, 2021

@graciousgrey can test it tomorrow

@graciousgrey graciousgrey added the bug Something isn't working label Jun 2, 2021
@graciousgrey
Copy link
Member

I can reproduce it. It happens only for some photos of my search result and it does not happen if I click reload before browsing photos in fullscreen mode

@darkenbula @guim31 could you test the following:

  1. If you have the search result, starting browsing from different photos and see if you have the same behaviour for all photos
  2. Once you have the search result and the filter set to newest first, click the reload button and see if you observe the same behaviour

Thank you!

@darkenbula
Copy link
Author

Best i can tell, if i close my browser and start over from scratch,. i get the unintended behaviour no matter where i start viewing the pictures from

If i refresh the page F5, it behaves correctly

lastzero added a commit that referenced this issue Jul 16, 2021
The observed behaviour appears to be a timing issue when opening an
image shortly after the search query / filter was changed, thus it
wasn't reproducible in a dev environment with only a few images.
@lastzero lastzero added the please-test Ready for acceptance test label Jul 16, 2021
@lastzero lastzero self-assigned this Jul 16, 2021
@graciousgrey graciousgrey added released Available in the stable release and removed please-test Ready for acceptance test labels Sep 26, 2021
@lastzero lastzero changed the title Searching then browsing not behaving as expected Photo Viewer: Searching then browsing shows the wrong images Nov 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working released Available in the stable release
Projects
Status: Release 🌈
Development

No branches or pull requests

4 participants