-
-
Notifications
You must be signed in to change notification settings - Fork 2k
Places: Fix RTL rendering on maps #1391
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
@haimkastner do you have an idea on how to fix this? :) |
I checked this issue, and it's reproduced even if the browser and the machine interfaces are in Hebrew. Seems to be a wrong configuration in the map component loading, I will dig into it to understand the issue root cause. |
This seems to be an issue in an underlying tiles service rather than PhotoPrism itself, isn't it? |
Please review the fix on PR #1393 Seems that an RTL plugin is required in order to support RTL. See the RTL documentation of Mapbox After adding it, the plugin is loaded by lazy only when Hebrew is shown on the map. As you can see in my environment: |
Our development preview and demo should be updated. Is this fixed for you there? |
Yes, the fix is there, and it looks good. |
Excellent, thanks for testing 👍 |
Recently installed photoprism via docker-compose in a debian host environment - working great and it's been slowly indexing the photos. I have many photos geotagged in Israel, and all the Hebrew names of cities, etc are displayed with the Hebrew letters in left-to-right order, and not the proper right-to-left. For example, Petah Tikva is displayed in English properly, but the name in Hebrew underneath is displaying as:
הווקת חתפ
Instead of:
פתח תקווה
See screenshot:

Tried changing the different map types but it's all pulling from the same API. Weirdly, if you load up OSM directly, on their site it's displaying the proper right-to-left Hebrew names:
https://www.openstreetmap.org/#map=15/32.0173/34.7597
Wondering what could be the cause of this bizarre display. I can confirm that the Arabic is properly displaying right-to-left, so not really sure why Hebrew is displaying in reverse....
Any ideas?
The text was updated successfully, but these errors were encountered: