Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calendar: Automatically hide months without (visible) pictures #1456

Closed
SiJiL82 opened this issue Aug 3, 2021 · 7 comments
Closed

Calendar: Automatically hide months without (visible) pictures #1456

SiJiL82 opened this issue Aug 3, 2021 · 7 comments
Assignees
Labels
enhancement Refactoring, improvement or maintenance task released Available in the stable release

Comments

@SiJiL82
Copy link

SiJiL82 commented Aug 3, 2021

After importing all my photos into PhotoPrism, I then archived some off that I didn't want included.
This has left some calendar months as having no non-archived photos in, and therefore show up just as black icons in the calendar view.
Reindexing the collection (or just the individual folder) doesn't remove these folders, leaving the calendar view looking less than pleasant.
Is there a way to force these to be hidden if there are no non-archived photos in that month?
image

@lastzero
Copy link
Member

lastzero commented Aug 3, 2021

No, as the archive is for "deleted" pictures. Would be strange if they still show up. Private pictures won't be used as well as that may leak them unintentionally.

@SiJiL82
Copy link
Author

SiJiL82 commented Aug 3, 2021

I'm not sure what you mean by "Would be strange if they still show up" - the pictures don't show up, I don't want them to show up either?
I'm happy that folders are empty, what I'm after is to not make that folder show up at all, as if I'd never had any photos taken in October 2012.

@lastzero
Copy link
Member

lastzero commented Aug 3, 2021

Sorry, I understood your problem was the "missing" preview image. Maybe we should exclude such months then - actually thought that is already the case. There might be a reason the implementation is like that. Already late over here and we're technically still on vacation. Taking a look later this week!

@SiJiL82
Copy link
Author

SiJiL82 commented Aug 3, 2021

Cool, thanks!

@graciousgrey graciousgrey added the enhancement Refactoring, improvement or maintenance task label Aug 4, 2021
@abhilesh
Copy link

abhilesh commented Aug 4, 2021

Just adding in, same thing happens when folders are auto-created under 'Places'/'States', 'Labels' and 'Moments'.
Sometimes the folders are auto-created based on incorrect tags, I manually edit the photos to correct the tags, the photos now move to the desired location but leave a blank folder with the incorrect tag.

Maybe hide/remove folders with zero elements?

@lastzero lastzero added the please-test Ready for acceptance test label Aug 29, 2021
@lastzero lastzero changed the title Calendar folders show as black icons if all items inside archived. Calendar: Hide months without (visible) pictures Aug 31, 2021
@lastzero lastzero changed the title Calendar: Hide months without (visible) pictures Calendar: Automatically hide months without (visible) pictures Aug 31, 2021
lastzero added a commit that referenced this issue Sep 6, 2021
@SiJiL82
Copy link
Author

SiJiL82 commented Sep 24, 2021

Happy to test this if needed - is there a way I can pull a docker image with the change in?

@graciousgrey
Copy link
Member

Our preview images includes the changes. Alternatively you can test on our demo: https://demo.photoprism.org/browse

@graciousgrey graciousgrey added released Available in the stable release and removed please-test Ready for acceptance test labels Sep 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Refactoring, improvement or maintenance task released Available in the stable release
Projects
Status: Release 🌈
Development

No branches or pull requests

4 participants