Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

People: Improve naming, renaming, and merging #1557

Closed
alexislefebvre opened this issue Sep 26, 2021 · 10 comments
Closed

People: Improve naming, renaming, and merging #1557

alexislefebvre opened this issue Sep 26, 2021 · 10 comments
Assignees
Labels
idea Feedback wanted / feature request please-test Ready for acceptance test released Available in the stable release

Comments

@alexislefebvre
Copy link
Contributor

alexislefebvre commented Sep 26, 2021

I had several images with faces, say person A and B. I wanted to change the tagged person A on one photo, so I changed the name to B. Now all the images with person A belong to person B, it looks like it merged the 2 persons. I think we should add a warning when changing one photo will affect several faces.

Workaround: press the eject button before changing a name: image

Side note: congrats that this new feature, this is great!

@jackbrown1993
Copy link

Agree, that some sort of confirmation or warning is required. Done this by mistake a couple of times now.

@graciousgrey
Copy link
Member

Changing the name without pressing the reject button will rename the person see: https://docs.photoprism.org/user-guide/organize/people/#rename-person. But obviously it is not that clear

@lastzero
Copy link
Member

lastzero commented Sep 26, 2021

That's exactly why we had the preview for testing. It works as designed. If you rename a person, it's renamed everywhere. Otherwise you need to press the button, so that PhotoPrism knows it's a DIFFERENT person. We'll improve our UI and docs to make this even more clear.

@alexislefebvre
Copy link
Contributor Author

@graciousgrey Thanks, my bad, I didn't read the doc before trying this new feature.

Here is the context:

image

The other tabs allow to edit data for only that photo, but changing the person here will affect all the related photos, this is surprising.

@lastzero
Copy link
Member

Probably best to disable editing names in the photo edit dialog at all to avoid mistakes.

@graciousgrey
Copy link
Member

@alexislefebvre no worries, it's good to have that feedback! Most people don't read the docs at all, so it should be as intuitive as possible :)

@lastzero lastzero self-assigned this Sep 29, 2021
@lastzero lastzero added the idea Feedback wanted / feature request label Sep 29, 2021
@lastzero lastzero changed the title Changing the person tagged on one image will change all related images People: Improve naming, renaming, and merging Sep 29, 2021
@lastzero
Copy link
Member

Started a new Development Preview build including the following changes:

  • You now have to confirm merging people on the People overview page when you name a person like an existing person.
  • Editing existing names in the photo edit dialog is disabled to avoid mistakes.
  • Orphan people and faces are removed automatically in the background, so that the count in the navigation always matches the actual search results.

@lastzero lastzero added the please-test Ready for acceptance test label Sep 29, 2021
@alexislefebvre
Copy link
Contributor Author

alexislefebvre commented Sep 30, 2021

Thank you.

I tried on the demo. I have set the name for a cluster, then I opened that show media with this person's face. When I pressed the eject button on one photo, it disconnected several photos from the same person.

And we can't mistakenly merge 2 people anymore. 👏

@lastzero
Copy link
Member

When I pressed the eject button on one photo, it disconnected several photos from the same person.

That actually depends on the face similarity as the software sees it. When similar faces belong to different people, it will separate them and create individual clusters. If needed also multiple clusters per person until the user stops reporting issues by pressing the eject button.

@lastzero
Copy link
Member

lastzero commented Oct 2, 2021

Released! 🥂

@lastzero lastzero closed this as completed Oct 2, 2021
@lastzero lastzero added the released Available in the stable release label Oct 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
idea Feedback wanted / feature request please-test Ready for acceptance test released Available in the stable release
Projects
Status: Release 🌈
Development

No branches or pull requests

4 participants