New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
People: Improve naming, renaming, and merging #1557
Comments
Agree, that some sort of confirmation or warning is required. Done this by mistake a couple of times now. |
Changing the name without pressing the reject button will rename the person see: https://docs.photoprism.org/user-guide/organize/people/#rename-person. But obviously it is not that clear |
That's exactly why we had the preview for testing. It works as designed. If you rename a person, it's renamed everywhere. Otherwise you need to press the button, so that PhotoPrism knows it's a DIFFERENT person. We'll improve our UI and docs to make this even more clear. |
@graciousgrey Thanks, my bad, I didn't read the doc before trying this new feature. Here is the context: The other tabs allow to edit data for only that photo, but changing the person here will affect all the related photos, this is surprising. |
Probably best to disable editing names in the photo edit dialog at all to avoid mistakes. |
@alexislefebvre no worries, it's good to have that feedback! Most people don't read the docs at all, so it should be as intuitive as possible :) |
Started a new Development Preview build including the following changes:
|
Thank you. I tried on the demo. I have set the name for a cluster, then I opened that show media with this person's face. When I pressed the eject button on one photo, it disconnected several photos from the same person. And we can't mistakenly merge 2 people anymore. 👏 |
That actually depends on the face similarity as the software sees it. When similar faces belong to different people, it will separate them and create individual clusters. If needed also multiple clusters per person until the user stops reporting issues by pressing the eject button. |
Released! 🥂 |
I had several images with faces, say person A and B. I wanted to change the tagged person A on one photo, so I changed the name to B. Now all the images with person A belong to person B, it looks like it merged the 2 persons. I think we should add a warning when changing one photo will affect several faces.
Workaround: press the eject button before changing a name:
Side note: congrats that this new feature, this is great!
The text was updated successfully, but these errors were encountered: