Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search: Query full-text index with title as fallback #1560

Closed
bm55 opened this issue Sep 27, 2021 · 11 comments
Closed

Search: Query full-text index with title as fallback #1560

bm55 opened this issue Sep 27, 2021 · 11 comments
Assignees
Labels
enhancement Refactoring, improvement or maintenance task released Available in the stable release

Comments

@bm55
Copy link

bm55 commented Sep 27, 2021

After installing the latest version the search without any filter only returns the pictures with people label. PhotoPrism doesn’t detect people in all images so the search result displays limited photos. Seems like the previous default search showed any photo that matches the search word in any metadata type. Can the default search behavior restored to previous version? We can always use the filter if we want to

@lastzero
Copy link
Member

Only if there is a person with that name, not in general. You don't want to find that person but only pictures with the name as keyword?

@lastzero
Copy link
Member

Note you can use the new labels and keywords search filters for this, which will ignore existing people.

@lastzero
Copy link
Member

Can you confirm this was the issue? Does the alternative work for you?

@bm55
Copy link
Author

bm55 commented Sep 27, 2021

yes, so if I type keywords:max, I get 7 pictures result. but if I just type max, I only get 1 result which is same result as person:max. It appears the default search without any filter is configured to use person filter now? can that be changed and instead use the keywords filter by default?

@lastzero
Copy link
Member

Could be changed, but wouldn't you expect an actual, known person to have a higher priority than a random keyword?

@bm55
Copy link
Author

bm55 commented Sep 28, 2021

Since the face detection doesn't detect all faces, I really think the default search should be the keywords that way all photos with certain keyword (title, keyword, subject, description) can be searched easily. I know how to use "keyword:max" but not all family members will remember to do that.

Also, the people search is already on the left navigation.

I have been spending a lot of time adding related keywords on all my photos (before adding it to PhotoPrism via Lightroom, and some within the PhotoPrism) so I can easily search and list all photos of family members, pets, friends, lakes, parks, and other objects. So I really hope you will consider changing the default search back to way it used to work in previous version.

Or even better, make is a user configured option via settings? default search options: 1. People 2. keywords or 3. People + keyworkds
What do you think?

@lastzero
Copy link
Member

That makes sense. Currently working on an update. Stay tuned.

@lastzero lastzero added the enhancement Refactoring, improvement or maintenance task label Sep 29, 2021
@lastzero lastzero self-assigned this Sep 29, 2021
@lastzero lastzero added the in-progress Somebody is working on this label Sep 29, 2021
lastzero added a commit that referenced this issue Sep 29, 2021
Default to photo name when search term is too short or on the stop list.
Search full text index otherwise, which now include names of people
(requires reindexing).
@lastzero lastzero changed the title Default search returns people only Search: Always use full-text index with photo name as fallback Sep 29, 2021
@lastzero
Copy link
Member

Started a new Development Preview build including the following changes:

  • People's names will be added to the full text index in the background and when editing photos.
  • Keep in mind index updates may take a while, they don't happen in real time.
  • Using the full text index means names matching a stopword like "img" won't be found.
  • If the query is too short for the full text index or matches a stopword, a photo name wildcard search will be performed instead.

@lastzero
Copy link
Member

Can be tested on our demo when the build is green: https://drone.photoprism.app/photoprism/photoprism/1915/1/5

@lastzero lastzero added please-test Ready for acceptance test and removed in-progress Somebody is working on this labels Sep 29, 2021
@lastzero lastzero changed the title Search: Always use full-text index with photo name as fallback Search: Prefer full-text index with title as fallback Sep 29, 2021
@lastzero lastzero changed the title Search: Prefer full-text index with title as fallback Search: Use full-text index with title as fallback Sep 29, 2021
@lastzero lastzero changed the title Search: Use full-text index with title as fallback Search: Query full-text index with title as fallback Sep 29, 2021
@lastzero
Copy link
Member

Makes sense to use the photo title instead of file name in case the query is too short for the full-text index.

@lastzero
Copy link
Member

lastzero commented Oct 2, 2021

Released! 🥂

@lastzero lastzero closed this as completed Oct 2, 2021
@graciousgrey graciousgrey added released Available in the stable release and removed please-test Ready for acceptance test labels Oct 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Refactoring, improvement or maintenance task released Available in the stable release
Projects
Status: Release 🌈
Development

No branches or pull requests

3 participants