Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Folders: Names listed in .ppignore should be ignored #1609

Closed
kvalev opened this issue Oct 7, 2021 · 4 comments
Closed

Folders: Names listed in .ppignore should be ignored #1609

kvalev opened this issue Oct 7, 2021 · 4 comments
Assignees
Labels
bug Something isn't working released Available in the stable release

Comments

@kvalev
Copy link
Contributor

kvalev commented Oct 7, 2021

When you click on the dropdown on the library index page, PhotoPrism will recursively crawl through all folders in originals and will create folder albums for every single one, even for paths which should be ignored by ppignore.

@lastzero lastzero self-assigned this Oct 8, 2021
@lastzero lastzero added the bug Something isn't working label Oct 8, 2021
@graciousgrey
Copy link
Member

Thanks for reporting!

@lastzero lastzero changed the title Folder crawling does not take ppignore into account Folders: Names listed in .ppignore should be ignored Oct 9, 2021
@lastzero lastzero added the please-test Ready for acceptance test label Oct 9, 2021
@lastzero
Copy link
Member

lastzero commented Oct 9, 2021

Ignore list wasn't properly initialized. Note that this fix won't remove existing folders from the index, just like files that are ignored after they were indexed already. This is to avoid terrible mistakes with wildcards (users - or their kids - might mistakenly add an .ppignore file with * to the originals folder, thus removing everything).

@kvalev
Copy link
Contributor Author

kvalev commented Oct 9, 2021

Thx for the quick fix!

@lastzero
Copy link
Member

You're welcome!

@graciousgrey graciousgrey added released Available in the stable release and removed please-test Ready for acceptance test labels Oct 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working released Available in the stable release
Projects
Status: Release 🌈
Development

No branches or pull requests

3 participants