Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

People: Faces in non-primary files cannot be named #1710

Closed
jackbrown1993 opened this issue Nov 9, 2021 · 7 comments
Closed

People: Faces in non-primary files cannot be named #1710

jackbrown1993 opened this issue Nov 9, 2021 · 7 comments
Assignees
Labels
bug Something isn't working released Available in the stable release

Comments

@jackbrown1993
Copy link

jackbrown1993 commented Nov 9, 2021

What does not work as expected?

A clear and concise description of what the bug is.

An error is seen in server logs and web GUI when trying to assign a Person to a cluster.

How can we reproduce it?

Steps to reproduce the behavior (on my instance):

  1. Go to 'People'
  2. Click on 'New'
  3. Choose the name from the dropdown.
  4. See error as per screenshot.

What behavior do you expect?

'New' face cluster to be assigned to known existing 'Person'.

Can you provide us with example files for testing or screenshots?

I don't think this bug is related to specific images. But the screenshot of the error is

Screenshot 2021-11-09 at 11 43 08

What version you are using?

PhotoPrism®211018-e200f322-Linux-x86_64

Any other helpful information?

Error log shows:

time="2021-11-09T11:39:25Z" level=debug msg="api: abort /api/v1/markers/:marker_uid with code 400 (Invalid request)"
time="2021-11-09T11:39:25Z" level=debug msg="marker: can't update markers for non-primary files (find)"
time="2021-11-09T11:39:25Z" level=debug msg="http: PUT /api/v1/markers/mr1ympb1e7lj4q7k (400) [4.921164ms]"

Out of the three faces I tried to add to existing 'People' two failed in the same way, one worked as expected.

If you are reporting a UI or performance issue, please always provide details about your...

  • Chrome on Mac
@jackbrown1993 jackbrown1993 added the bug Something isn't working label Nov 9, 2021
@lastzero
Copy link
Member

lastzero commented Nov 9, 2021

That's interesting because non-primary files shouldn't have markers indeed. Did you manually change primary files or run index purge / cleanup commands?

Thanks for reporting! The first section should actually contain your bug description and not our placeholder text 😉

@lastzero lastzero self-assigned this Nov 9, 2021
@jackbrown1993
Copy link
Author

Yes, I ran some of those commands as part of #1594 , I actually still see some broken thumbnails. Was just away on holiday so never got a chance to follow up.

@lastzero
Copy link
Member

lastzero commented Nov 9, 2021

This should fix it. Started a new preview build for testing: https://drone.photoprism.app/photoprism/photoprism/2285

@lastzero lastzero added the please-test Ready for acceptance test label Nov 9, 2021
@lastzero lastzero changed the title Bug: Invalid Request when naming 'New' face. People: Faces in non-primary files cannot be named Nov 9, 2021
@lastzero
Copy link
Member

lastzero commented Nov 9, 2021

It would be great if you could try our development preview to test if the problem is fixed:

https://docs.photoprism.org/release-notes/#development-preview

@jackbrown1993
Copy link
Author

Once on the build do I need to re-index or anything before testing?

@jackbrown1993
Copy link
Author

jackbrown1993 commented Nov 10, 2021

I am now using the preview build and can confirm I no longer see the error and faces can be named as expected. Thank you!

@lastzero
Copy link
Member

Excellent, thanks for testing!

@graciousgrey graciousgrey added released Available in the stable release and removed please-test Ready for acceptance test labels Nov 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working released Available in the stable release
Projects
Status: Release 🌈
Development

No branches or pull requests

3 participants