Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Places: Incorrect state information for locations around Paris #1776

Closed
kvalev opened this issue Nov 29, 2021 · 5 comments
Closed

Places: Incorrect state information for locations around Paris #1776

kvalev opened this issue Nov 29, 2021 · 5 comments
Assignees
Labels
bug Something isn't working released Available in the stable release

Comments

@kvalev
Copy link
Contributor

kvalev commented Nov 29, 2021

I discovered a bunch of high-profile locations in and around Paris that have the wrong state information. Below are two examples.

Versailles
https://places.photoprism.app/v1/location/47e67db946ec
https://nominatim.openstreetmap.org/ui/details.html?osmtype=R&osmid=9087588&class=tourism

Louvre
https://places.photoprism.app/v1/location/47e66e2672b4
https://nominatim.openstreetmap.org/ui/details.html?osmtype=W&osmid=568455193&class=tourism

In both cases (and a bunch of others I have noticed), the places API reports the state as France métropolitaine (mainland France), even tho the data in Nominatim correctly shows the state being Île-de-France (admin level 4).

@kvalev kvalev added the bug Something isn't working label Nov 29, 2021
@lastzero lastzero self-assigned this Nov 29, 2021
@lastzero lastzero added the please-test Ready for acceptance test label Nov 30, 2021
lastzero added a commit that referenced this issue Nov 30, 2021
@kvalev
Copy link
Contributor Author

kvalev commented Nov 30, 2021

Thanks a lot for the quick fix! Now the state information in places is correct 👏

However I dont think the mapping in code is correct - France métropolitaine stands for mainland France (meaning the European part France without all the overseas territories). As such it cannot be mapped to a state - this would be like mapping Germany to Berlin.

@lastzero
Copy link
Member

This isn't a state, so it must be mapped to something. Won't happen if the state is correct. Not sure why photon does this, but Nominatim is correct. So it's double fixed.

@lastzero
Copy link
Member

Note that other fields such as name and category have changed as well. Wasn't fixed with mapping.

@kvalev
Copy link
Contributor Author

kvalev commented Nov 30, 2021

I still think it is wrong to have the mapping, but you are right - as long as the Places API returns the right data, the mapping wont be used.
Anyway I ran few tests and the geo-data is now perfect! Thanks a lot!

@graciousgrey graciousgrey added released Available in the stable release and removed please-test Ready for acceptance test labels Dec 1, 2021
@lastzero
Copy link
Member

lastzero commented Dec 6, 2021

Issue seems to be fixed in Photon meanwhile.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working released Available in the stable release
Projects
Status: Release 🌈
Development

No branches or pull requests

3 participants