-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Places: Incorrect state information for locations around Paris #1776
Comments
Thanks a lot for the quick fix! Now the state information in places is correct 👏 However I dont think the mapping in code is correct - |
This isn't a state, so it must be mapped to something. Won't happen if the state is correct. Not sure why photon does this, but Nominatim is correct. So it's double fixed. |
Note that other fields such as name and category have changed as well. Wasn't fixed with mapping. |
I still think it is wrong to have the mapping, but you are right - as long as the Places API returns the right data, the mapping wont be used. |
Issue seems to be fixed in Photon meanwhile. |
I discovered a bunch of high-profile locations in and around Paris that have the wrong state information. Below are two examples.
Versailles
https://places.photoprism.app/v1/location/47e67db946ec
https://nominatim.openstreetmap.org/ui/details.html?osmtype=R&osmid=9087588&class=tourism
Louvre
https://places.photoprism.app/v1/location/47e66e2672b4
https://nominatim.openstreetmap.org/ui/details.html?osmtype=W&osmid=568455193&class=tourism
In both cases (and a bunch of others I have noticed), the places API reports the state as
France métropolitaine
(mainland France), even tho the data in Nominatim correctly shows the state beingÎle-de-France
(admin level 4).The text was updated successfully, but these errors were encountered: