Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve authentication and websocket security #216

Closed
lastzero opened this issue Jan 22, 2020 · 4 comments
Closed

Improve authentication and websocket security #216

lastzero opened this issue Jan 22, 2020 · 4 comments
Assignees
@lastzero
Labels
enhancement Refactoring, improvement or maintenance task released Available in the stable release
Milestone
MVP

Comments

@lastzero
Copy link
Member

As a user, I want to run PhotoPrism without hiding it behind additional auth mechanisms.

See #167 (comment):

Make everything private by default (and behind a login) and allow me to share albums or pictures by generating. Right now I'm hiding Photoprism behind a basic HTTP auth mechanism on top of the Kubernetes ingress.
@lastzero lastzero self-assigned this Jan 22, 2020
@lastzero lastzero added in-progress Somebody is working on this enhancement Refactoring, improvement or maintenance task labels Jan 22, 2020
@lastzero lastzero added this to the MVP milestone Jan 22, 2020
@lastzero
Copy link
Member Author

First commit for this: f569c3a

lastzero added a commit that referenced this issue Jan 22, 2020
@lastzero
Add Websocket authentication #216
7342d51 
Signed-off-by: Michael Mayer <michael@liquidbytes.net>
@lastzero
Copy link
Member Author

Screenshot 2020-01-22 at 16 50 00

lastzero added a commit that referenced this issue Jan 22, 2020
@lastzero
Fix JS session test #216
2794fec 
Signed-off-by: Michael Mayer <michael@liquidbytes.net>
lastzero added a commit that referenced this issue Jan 23, 2020
@lastzero
Only send full clientConfig if authenticated #216
2f4840f 
Signed-off-by: Michael Mayer <michael@liquidbytes.net>
@lastzero
Copy link
Member Author

@casidiablo Since you asked for it: Maybe you want to test this? :)

Screenshot 2020-01-23 at 07 47 45

@lastzero lastzero added please-test Ready for acceptance test and removed in-progress Somebody is working on this labels Jan 23, 2020
@casidiablo
Copy link

Works for me

@lastzero lastzero added released Available in the stable release and removed please-test Ready for acceptance test labels Jan 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lastzero lastzero

Labels
enhancement Refactoring, improvement or maintenance task released Available in the stable release
Projects
None yet
Milestone
MVP
Development

No branches or pull requests
2 participants
@casidiablo @lastzero