Albums: Replace ASCII double quotes in titles with Unicode quotes instead of single quotes

[dror3go]

Following #1196 where we enabled keywords with single/double quotation marks, PhotoPrism currently converts double quotation marks in album titles with single quotation marks.
Though not a high priority bug, it feels weird for users in languages which make use of double quotation marks for acronyms.

[lastzero]

Think that was a precaution measure in the aftermath of the log4j debacle. Double quotes would also simplify code injection and may not be supported on many filesystems in case you want to use album names for zip files or as folder names. As such, it's a decision we made (for now) and not a bug. Feel free to help with improving our docs so that it does not look as that happened by mistake and should be reported as a bug.

[dror3go]

While I understand the technical rationale - as an end user I still find it to be a bug.
Though not a German speaker myself, I think it's a little bit like if German letters such as Ä and Ö would've been replaced with A and O.
As I mentioned in the original post - I think it's not a high priority issue, but still an issue nonetheless. I feel that labeling it as documentation issue is saying it's WONTFIX and I should expect this behavior to remain as-is.

Adding a note on the docs wouldn't improve anything from my perspective - I just don't think that an end user should be expected to read the docs just like I'm not reading manual guides of a new TV for example. Ideally things should work "as expected".

[lastzero]

Would have been replaced? Where? How?

[dror3go]

They're not, that's my point.
As an end user - would you think it was a bug if PhotoPrism replaced the first two letters to "OA"?

[lastzero]

בּד״א
works as well
״ is not the same as "

[lastzero]

All of the examples I found on https://www.myjewishlearning.com/article/a-guide-to-jewish-acronyms-and-abbreviations/ can be used as album names, just not the ASCII " which would require escaping and a lot of security checks and which technically is not the right character for RTL languages either as it is LTR.

[lastzero]

Would you be happy if we convert " to a proper Unicode character?