Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stacks: Search + manually stack similar images #28

Open
lastzero opened this issue Oct 8, 2018 · 11 comments
Open

Stacks: Search + manually stack similar images #28

lastzero opened this issue Oct 8, 2018 · 11 comments
Labels
idea Feedback wanted / feature request priority Supported by early sponsors or popular demand

Comments

@lastzero
Copy link
Member

lastzero commented Oct 8, 2018

Perceptual hashing is already implemented, all we need is a user interface and maybe an easy way to merge multiple files into one photo.

@lastzero lastzero added the idea Feedback wanted / feature request label Oct 8, 2018
@lastzero lastzero added this to To do in Product Development & UX via automation Oct 8, 2018
@lastzero lastzero added the low-priority Everything nice to have but not so important label Nov 18, 2018
@rkkoszewski
Copy link

What about non-destructive merging? Where the main picture is shown as normal, but the similar pictures are still accessible from an option at the image. Just like the time-shift option in many phones, which take a burst of pictures when you make a picture and you can select the best one retrospectively while still preserving all alternatives.

@lastzero
Copy link
Member Author

@rkkoszewski Yes, this is how it should look like when it's done. The database has a table for photos and files for that reason, so you can have multiple files for a photo.

@lastzero lastzero added unfunded and removed low-priority Everything nice to have but not so important labels Dec 30, 2019
@issuehunt-oss
Copy link

issuehunt-oss bot commented Apr 26, 2020

An anonymous user has funded $15.00 to this issue.


@lastzero
Copy link
Member Author

We've recently added a "Group by similarity" sort option to our photo search, it uses perceptual image hashes: https://demo.photoprism.org/photos?view=cards&order=similar&public=true&quality=3

@spiritbroski
Copy link

spiritbroski commented Nov 16, 2020

@lastzero when i try that link the photo doesnt order by similiarity just look at this photo of a girl :
image
this is the first photo of the girl on the right side
image
this is the second photo way below from the first photo can you elaborate more on what do you mean by similiarity here or is the algorithm still wrong because the order i think still not right

when i look again actually both photo is not similiar the first photo the girl is a little bit smirk but the second one just natural smile but i think the different is too much also

@graciousgrey graciousgrey changed the title Search / merge similar images Search + manually stack similar images Nov 26, 2020
@timdonovanuk
Copy link

@graciousgrey am I overlooking something or is stacking not in the currently API (even though its clearly implemented)? Unstacking seems to be! I was planning to call it to stack a whole bunch of semi-duplicates I have.

@lastzero
Copy link
Member Author

Stacking happens based on the file name or metadata. There is currently no way to manually stack random files without renaming / moving them or changing their metadata in any way. For example you could set a unique image ID (Exif) or document ID (XMP) and then reindex to get files stacked.

@timdonovanuk
Copy link

Ah righty, understood. Thanks @lastzero !

@graciousgrey graciousgrey added the priority Supported by early sponsors or popular demand label Oct 13, 2021
@graciousgrey graciousgrey changed the title Search + manually stack similar images Stacks: Search + manually stack similar images Nov 3, 2021
@GlassedSilver
Copy link

GlassedSilver commented Mar 28, 2022

I would definitely welcome an option to not stack based on perceptional hashing, at least not automatically. Maybe with a review process and manually selecting my favored pick.

Sample:
Screenshot 2022-03-28 225922

Three of these files certainly belong in this stack whilst IMG_8707_edited.JPG should be the one that gets displayed automatically.

IMG_8708.JPG has no business being in the stack until I give permission in my point of view. (as in: that's really just my opinion, as in my preference. I'd love to be able to set that as an option)

@graciousgrey
Copy link
Member

@GlassedSilver PhotoPrism stacks files for the reasons mentioned here: https://docs.photoprism.app/user-guide/organize/stacks/#for-what-reasons-can-files-be-stacked. All of them can be turned off in settings.
Images are not yet stacked automatically due to similarity. Using edited versions as primary file is on our to do (#1028) :)

@GlassedSilver
Copy link

@GlassedSilver PhotoPrism stacks files for the reasons mentioned here: https://docs.photoprism.app/user-guide/organize/stacks/#for-what-reasons-can-files-be-stacked. All of them can be turned off in settings. Images are not yet stacked automatically due to similarity. Using edited versions as primary file is on our to do (#1028) :)

I think what may have been the issue with the files I had was that they got taken shortly after one another within the same second at the same location. I turned off that setting, let's see how further imports go. :)

As for the edits becoming primaries by default... Damn I love when things I would like to address are already on the radar! :D

I've only tried this application for a few days now, but I'm already liking a lot about it. Live Photo support being one of the key features I miss in almost any other similar product.

But also that the vision in general and the wealth of features are matching my preferences. This app is starting to feel like home.

Oh, and major probs for not being subscription-only on premium features and not locking them behind some extra protected download, but being true gentlemen about it.

This is what had me even consider sponsoring this project. The more I feel pressured to do it the more likely I am to go another way, but you folks are highly respectful about this concept, so I definitely went in with a sponsorship.

I'll likely be a "repeat offender" on that front, because I think it's well worth giving back the respect that you bring towards users by not trying to be the millionth outlet to ask for a coffee a month. Makes me that much more likely to give more than that in the long run.

Sorry that I digressed. Just wanted to share my enthusiasm!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
idea Feedback wanted / feature request priority Supported by early sponsors or popular demand
Projects
Status: Ideas 💭
Development

No branches or pull requests

6 participants