Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MariaDB: Make version check compatible with 10.10 #2913

Closed
lastzero opened this issue Nov 18, 2022 · 2 comments
Closed

MariaDB: Make version check compatible with 10.10 #2913

lastzero opened this issue Nov 18, 2022 · 2 comments
Assignees
Labels
bug Something isn't working priority Supported by early sponsors or popular demand released Available in the stable release

Comments

@lastzero
Copy link
Member

The system variable innodb_version is missing in MariaDB 10.10, unclear if accidentally or intentionally. Since this causes an error in the MariaDB version check, we must assume that it is a compatible release. In all other releases down to MySQL 8 this variable is set to the plain version (without additions like the application name or distribution which could cause parse errors).

@lastzero lastzero self-assigned this Nov 18, 2022
@lastzero lastzero added bug Something isn't working important labels Nov 18, 2022
lastzero added a commit that referenced this issue Nov 18, 2022
Signed-off-by: Michael Mayer <michael@photoprism.app>
@lastzero lastzero added please-test Ready for acceptance test released Available in the stable release and removed please-test Ready for acceptance test labels Nov 18, 2022
@lastzero
Copy link
Member Author

This fix has been released, a new stable build will be available soon:

Note that MariaDB 10.10.2 has only been released yesterday. Since we can't see into the future, reacting this fast is the best we can do in case something unexpectedly changes in a new MariaDB version.

We recommend that you check compatibility before you upgrade to a brand new MariaDB version and don't use the latest tag.

chain710 pushed a commit to chain710/photoprism that referenced this issue Nov 28, 2022
* merge-221118: (66 commits)
  Frontend: Update deps in package-lock.json
  Frontend: Update translations.json
  UI: Add Electra theme photoprism#2916
  MariaDB: Make version check compatible with 10.10 photoprism#2913
  Weblate: Update backend translations
  Weblate: Update frontend translations
  Backend: Upgrade golang.org/x/crypto in go.mod and go.sum
  Develop: Upgrade base image from 221116-jammy to 221117-jammy
  CI: Update "docker-develop-latest" target in Makefile
  CI: Update deploy-develop.sh script
  MariaDB: Upgrade pre-installed client from v10.6 to v10.9
  Videos: Add "intel" init target to force driver installation photoprism#2700
  Metadata: Improve data parsing and sanitization photoprism#2897
  Frontend: Update translations.json and package-lock.json
  Weblate: Update frontend translations
  Develop: Upgrade base image from 221102-jammy to 221116-jammy
  Frontend: Update translations.json
  Frontend: update options.js
  Weblate: Update frontend translations
  Weblate: Update backend translations
  ...
@lastzero
Copy link
Member Author

We have updated our documentation for you to clarify which versions are supported and what the best upgrade strategy is:

Our configuration examples are usually based on the current stable version to take advantage of performance improvements. This does not mean that older versions are no longer supported and you must upgrade immediately.

Since it is possible that new major versions of MariaDB require changes in PhotoPrism to be compatible, you should check compatibility before upgrading to new MariaDB versions that have been released very recently. We therefore recommend not using the :latest tag for the Docker image and to upgrade manually by changing the tag e.g. from :10.8 to :10.9 once we had the chance to test the new release:

services:
  mariadb:
    image: mariadb:10.9
    ...

@lastzero lastzero added the priority Supported by early sponsors or popular demand label Dec 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working priority Supported by early sponsors or popular demand released Available in the stable release
Projects
Status: Release 🌈
Development

No branches or pull requests

1 participant