New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Library: Stack files with vendor-specific naming schemes as used by Apple and iCloudPD #2983
Comments
I would love to see thix implemented :) (this is the same request as made here) |
@Soulplayer Thank you! I wasn't aware of this issue. The more our project grows, the harder it gets to stay on top of things :) |
As also mentioned in the related GitHub discussion, please note that |
I'll also post it here:
So the _HEVC. addition causes a problem for the stacking. Thank you for your development. Proud sponsor! |
As a workaround, you could move all affected files out of originals, run photoprism index & cleanup to purge the index and sidecars for those files, then move them back in with a script that replaces |
Since a lot of people are using it, we'll add a hack (as we did for Apple's _E for "edited") when we have a bit of time, and hope it doesn't break anything. Unfortunately, we're completely maxed out right now working on many different issues/PRs at the same time. If I forget, feel free to send a reminder in 4 to 8 weeks. |
Signed-off-by: Michael Mayer <michael@photoprism.app>
@epheterson @graciousgrey My changes can improve indexing of (related) media files as created by Apple/iCloudPD in special situations, e.g. in case of a partial index update where However, I have found that ignoring the When I had this stacking option enabled, indexing Live Photos with filenames as used by Apple/iCloudPD worked for me without any issues (unless the files were already indexed): (a) Contrary to my earlier assumption, this means that it makes no sense to reuse/extend the following function, which is currently used to find additional versions of files edited with Apple devices: photoprism/internal/photoprism/mediafile.go Lines 444 to 455 in 54f281a
(b) In addition, I noticed that adding settings for stacking with user-defined naming patterns already seems to be covered by this more general feature request: Based on these findings, it seems best (for now) to improve our documentation (e.g., the First Steps tutorial) to include a note on related files created by Apple/iCloudPD, with the recommendation to enable stacking by Sequential Name? |
Signed-off-by: Michael Mayer <michael@photoprism.app>
@Soulplayer @epheterson @graciousgrey After looking at the problem again today, I was able to find an alternative solution that is a combination of the changes I made yesterday and the approach I originally proposed. An updated preview build will be available for testing soon! ✨ |
Describe what problem this solves and why this would be valuable to many users
A fair amount of users backup photos with the iCloudPD docker package, which downloads Live Photos by default. The format used by iCloudPD does not automatically generate Live Photos within PhotoPrism. The issue is similar to #1885, though with a different naming scheme, and can be worked around in the same way by enabling Sequential Names for stacking.
Example filenames –
IMG_0108_HEVC.MOV
IMG_0108.HEIC
Describe the solution you'd like
Ideally PhotoPrism could notice the same image number with unique filetypes and the "_HEVC" appended to automatically create a Live Photo without having to first enable the Sequential Names stacks feature.
Describe alternatives you've considered
Alternatively we can keep things as-is and expect users to discover the feature. Unfortunately even a complete re-index does not stack the photos so it can lead to some data loss to purge/re-index to fix.
The text was updated successfully, but these errors were encountered: