-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Backups: Improve commands to better handle large index dumps #3140
Comments
Can you also verify if this could be a macOS / Apple Silicon specific issue? From what I know, Docker services are running inside a VM there, so the effective "hardware" specs might be different. |
Yes I tried this on a MacBook Pro running Intel on a dev photoprism build and was able to reproduce. Looks like in this case I do see a log for
|
What is your memory limit for Docker? Note this is a separate setting in Docker Desktop. It's not your total system memory. |
The Docker memory limit on my Mac mini it was set to 6GB, on this MacBook Pro it was set to 4GB. I raised my MBP limit to 8GB and it worked but still think it's an issue because the plain mysqldump command works fine, the issue is when the output goes through the Golang ByteBuffer. |
It seems possible that the command requires twice the amount of memory due to the conversion or output handling. |
From my understanding, these changes should write the sql dump directly to a file or to stdout, so no buffer is needed. I've started a new development preview build for you to test this. Any help is greatly appreciated, as it allows our team to work on other issues that our community is waiting for. Thank you very much! |
This is ready for testing. We appreciate your help! |
…prism#3140 See also photoprism#3301, photoprism#3311, and photoprism#3298. Signed-off-by: Michael Mayer <michael@photoprism.app>
It appears that if the SQL db is too large, the backup command silently fails when writing the buffer to string.
I have 2 photoprism containers, the one with a
1.17GB
DB fails to output the dump while the260MB
DB dumps successfully.Looking at the logic and the run time of the command, it looks like this block is not running properly. I suspect its due to the size of my DB and maybe out.String() on either 162 (both file and stdout doesn't work) or 165 is reaching some limitation. Clearly the logic is dropping off somewhere between line 152 and 169...
macOS 13.1 M1
Docker 4.15.0 (4 CPUs, 6GB RAM allocated)
photoprism:latest
MariaDB:10.10
Full context and details in the discussion.
Originally posted by @dsuresh-ap in #772 (comment)
The text was updated successfully, but these errors were encountered: