-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CLI: Create thumbs and convert files in deterministic order #3194
Comments
That's expected (and documented to my knowledge) as you can't ignore JPEGs (primary file format) nor all files (required to use the application). |
You're saying the .ppignore can't ignore JPEGs, or the thumbs command can't? I assume the latter, but why is that? Directories/files ignored by the .ppignore file are not indexed, so what is the use of thumbnails for those? In my situation in have about 60.000 files that I want PhotoPrism to ignore (contained within several subdirectories), the .ppignore files work great for that. However I have to regenerate the thumbs due to some corruption issues (missing thumbnails), and now I end up with an additional 660.000 or so useless thumbnails. If this is working as intended then maybe it would be nice if we could run the thumbs command only on a certain sub directory within the originals folder (or sidecar folder for that matter?). |
|
This also adds support for specifying a path to the thumbs command. Signed-off-by: Michael Mayer <michael@photoprism.app>
When I checked the problem in our code, I found that the thumbs and convert commands processed files in a non-deterministic order. This was intentional, but could cause the .ppignore file to load after the first file had been processed, and was therefore unreliable. The last commit fixes this behavior by processing the files deterministically (and a bit slower). In addition, you can now specify a subfolder when using the thumbs command. |
I've started a new preview build for testing! It should be available in about one hour. |
Just tested, I assume Anyhow: BUG resolved! Thanks @lastzero |
Indeed, the wildcard works as well. Just not for related files, e.g. if you exclude JPEGs but not RAW files. In this case PhotoPrism still uses JPEG sidecar files. |
1. Problem:
When running
photoprism thumbs
I can see in the debug logs that thumbnails are being created for files in folders that are otherwise ignored by the indexer (due to the.ppignore
files).log lines like these appear:
I can also see files being created in the cache folder for the images that should be ignored.
2. Reproduce:
Setup an ignored folder using a
.ppignore
file (put it inside of the folder you want to ignore), then runphotoprism thumbs
.Example contents:
3. Expected behavior:
Thumbnails should not be created for files that are supposed to be ignored by the
.ppignore
files.4. Environment:
4a. Software
4b. Hardware
The text was updated successfully, but these errors were encountered: