Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Videos: Add .dv to the list of known video file extensions #3226

Closed
benklop opened this issue Feb 22, 2023 · 15 comments
Closed

Videos: Add .dv to the list of known video file extensions #3226

benklop opened this issue Feb 22, 2023 · 15 comments
Assignees
Labels
idea Feedback wanted / feature request released Available in the stable release video Video Formats, Transcoding, FFmpeg, Streaming & Co

Comments

@benklop
Copy link

benklop commented Feb 22, 2023

As a user with old DV video files withh the extension .dv in my library, I would like photoprism to index and thumbnail these videos without having to transcode them manually beforehand.

@benklop benklop added the idea Feedback wanted / feature request label Feb 22, 2023
@lastzero
Copy link
Member

Do you have a sample file for testing?

lastzero added a commit that referenced this issue Feb 22, 2023
Note that this is completely untested as we have no sample files.

Signed-off-by: Michael Mayer <michael@photoprism.app>
@lastzero lastzero changed the title Videos: Index .dv video Videos: Add .dv to the list of known video file extensions Feb 22, 2023
@lastzero lastzero added the please-test Ready for acceptance test label Feb 22, 2023
@lastzero
Copy link
Member

Actual support depends on FFmpeg, so needs to be tested. We'll provide a new development preview later today for you to experiment! Note there's probably not much we can do if it doesn't work.

@lastzero lastzero added the video Video Formats, Transcoding, FFmpeg, Streaming & Co label Feb 22, 2023
@benklop
Copy link
Author

benklop commented Feb 22, 2023

I do have a sample file but github won't let me attach it. I'll try zipping it up.

@benklop
Copy link
Author

benklop commented Feb 22, 2023

Wedding & reception001.dv.zip

VLC Plays this fine, so I'm hopeful FFmpeg is able to deal with it with no trouble

@lastzero
Copy link
Member

Was it okay to upload your sample to https://dl.photoprism.app/samples/DV/ so we can continue to use it for testing?

@benklop
Copy link
Author

benklop commented Feb 23, 2023

yes, that's fine with me.

@benklop
Copy link
Author

benklop commented Feb 23, 2023

The current preview doesn't appear to contain the commit including DV video - should I just build my own copy with that commit?

@lastzero
Copy link
Member

Still busy optimizing index performance. Going to build a new preview after that.

@benklop
Copy link
Author

benklop commented Feb 23, 2023

I've confirmed on a local build that with this change .dv files do in fact get recognized, thumbnailed, and play back properly, so FFmpeg does in fact work properly with these.

@lastzero
Copy link
Member

Thanks for testing it! One more format supported 💐

@lastzero lastzero added tested Changes have been tested successfully and removed please-test Ready for acceptance test labels Feb 23, 2023
@benklop
Copy link
Author

benklop commented Feb 23, 2023

I noticed today after testing this in my full library that the detected length for the dv video is not correct, by a large margin sometimes. This seems like it would have to be an FFmpeg issue but i'm not certain.

@benklop
Copy link
Author

benklop commented Feb 23, 2023

it actually seems like it might be a consistent 32 or 33 seconds extra length

@lastzero
Copy link
Member

It could be that only the number of frames is known. In this case we assume 30 FPS, but this is not necessarily correct, so the calculated length may be wrong.

@benklop
Copy link
Author

benklop commented Feb 23, 2023

ok. I'll see if I can determine things more clearly. The sample i provided earlier is 6 seconds long but is detected as 36 seconds long, which seems too large of a margin to be due to framerate. VLC show the framerate as 29.97, so I don't think it's likely the difference is from assuming 30 fps.

@benklop
Copy link
Author

benklop commented Feb 23, 2023

it looks like it is exactly 30 extra seconds for other videos I have checked as well.

seeschloss pushed a commit to seeschloss/photoprism that referenced this issue Apr 10, 2023
Note that this is completely untested as we have no sample files.

Signed-off-by: Michael Mayer <michael@photoprism.app>
@graciousgrey graciousgrey added released Available in the stable release and removed tested Changes have been tested successfully labels May 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
idea Feedback wanted / feature request released Available in the stable release video Video Formats, Transcoding, FFmpeg, Streaming & Co
Projects
Status: Release 🌈
Development

No branches or pull requests

3 participants