-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Videos: Add .dv to the list of known video file extensions #3226
Comments
Do you have a sample file for testing? |
Note that this is completely untested as we have no sample files. Signed-off-by: Michael Mayer <michael@photoprism.app>
Actual support depends on FFmpeg, so needs to be tested. We'll provide a new development preview later today for you to experiment! Note there's probably not much we can do if it doesn't work. |
I do have a sample file but github won't let me attach it. I'll try zipping it up. |
VLC Plays this fine, so I'm hopeful FFmpeg is able to deal with it with no trouble |
Was it okay to upload your sample to https://dl.photoprism.app/samples/DV/ so we can continue to use it for testing? |
yes, that's fine with me. |
The current preview doesn't appear to contain the commit including DV video - should I just build my own copy with that commit? |
Still busy optimizing index performance. Going to build a new preview after that. |
I've confirmed on a local build that with this change |
Thanks for testing it! One more format supported 💐 |
I noticed today after testing this in my full library that the detected length for the dv video is not correct, by a large margin sometimes. This seems like it would have to be an FFmpeg issue but i'm not certain. |
it actually seems like it might be a consistent 32 or 33 seconds extra length |
It could be that only the number of frames is known. In this case we assume 30 FPS, but this is not necessarily correct, so the calculated length may be wrong. |
ok. I'll see if I can determine things more clearly. The sample i provided earlier is 6 seconds long but is detected as 36 seconds long, which seems too large of a margin to be due to framerate. VLC show the framerate as 29.97, so I don't think it's likely the difference is from assuming 30 fps. |
it looks like it is exactly 30 extra seconds for other videos I have checked as well. |
Note that this is completely untested as we have no sample files. Signed-off-by: Michael Mayer <michael@photoprism.app>
As a user with old DV video files withh the extension .dv in my library, I would like photoprism to index and thumbnail these videos without having to transcode them manually beforehand.
The text was updated successfully, but these errors were encountered: